You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "mpritt (via GitHub)" <gi...@apache.org> on 2025/02/13 22:58:40 UTC
[PR] Adding Integrity and CrossOrigin values to ResourceReference and related code [wicket]
mpritt opened a new pull request, #1102:
URL: https://github.com/apache/wicket/pull/1102
**Synopsis**
Added two new variables to the ResourceReference class. Added code to use these values in both the JavaScriptReferenceHeaderItem and CssReferenceHeaderItem classes. Also fixed a bug with the AbstractCssReferenceHeaderItem class where it was directly accessing the identity and crossOrigin values directly instead of going through accessor methods.
**In-depth Detail**:
It is easy to create the integrity and cross origin values needed when the we have the control over the creation of the JavaScriptHeaderItem or CssReferenceHeaderItem. It becomes much more difficult when there are resources that are created and then stored in wicket framework classes (whether resource references are framework or user created), because these resources are used later by the framework when it does the actual creation of the header items (i.e. like JavaScriptHeaderItem.forReference()).
Supporting scenario...try setting the integrity hash for the "wicket-ajax-jquery.js" file which is referenced from the wicket-core-10.1.0.jar. This resource is created initially through the WicketAjaxJQueryResourceReference class and used in the JavaScriptLibrarySettings class. The call getWicketAjaxReference() inside the JavaScriptLibrarySettings is used by the framework in various places, and those places create the actual JavaScriptReferenceHeaderItem (see OnDomReadyHeaderItem.getDependencies() as an example). While it is possible to extend a few framework classes to overwrite the default behavior and create the JavaScriptReferenceHeaderItem directly and add the desired hash and cross-origin values, that method is not a desirable or maintainable.
By adding integrity and cross-origin variables to the definition of a ResourceReference class, those values can then be used in the rendering of the JavaScriptReferenceHeaderItem through overriding the getIntegrity() and getCrossOrigin() functions. If the header item's integrity value was not defined (i.e. null) then use the value defined from the ResourceReference (the same goes for the cross origin value).
It was also noticed that the AbstractCssReferenceHeaderItem's internalRenderCSSReference() function was not correctly referencing the integrity and cross origin values by directly accessing the values rather than using the accessor methods. Changes were made to this class to correctly use the accessor methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WICKET-7149: Add Integrity and CrossOrigin values to ResourceReference and related code [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1102:
URL: https://github.com/apache/wicket/pull/1102#issuecomment-2670810799
Thank you, @mpritt !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WICKET-7149: Add Integrity and CrossOrigin values to ResourceReference and related code [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #1102:
URL: https://github.com/apache/wicket/pull/1102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding Integrity and CrossOrigin values to ResourceReference and related code [wicket]
Posted by "mpritt (via GitHub)" <gi...@apache.org>.
mpritt commented on PR #1102:
URL: https://github.com/apache/wicket/pull/1102#issuecomment-2664199376
Added unit tests for related changes.
From: Andrea Del Bene ***@***.***>
Sent: Monday, February 17, 2025 9:42 AM
To: apache/wicket ***@***.***>
Cc: Michael Pritt ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [apache/wicket] Adding Integrity and CrossOrigin values to ResourceReference and related code (PR #1102)
BE CAREFUL:
This email originated from outside the organization. Do not click links, open attachments, or enter user credentials, unless you recognize the sender and know the content is safe.
BE CAREFUL:
@bitstorm approved this pull request.
—
Reply to this email directly, view it on GitHub<https://github.com/apache/wicket/pull/1102#pullrequestreview-2621542049>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL5EAOZGSZBMAA3EXIAQGUD2QIGNTAVCNFSM6AAAAABXDKOJACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRRGU2DEMBUHE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org