You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/02/07 02:55:49 UTC
[GitHub] [rocketmq] caigy commented on a change in pull request #3809: improve DefaultMQProducerImpl code
caigy commented on a change in pull request #3809:
URL: https://github.com/apache/rocketmq/pull/3809#discussion_r800286101
##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
##########
@@ -326,11 +324,9 @@ public void run() {
try {
if (transactionCheckListener != null) {
localTransactionState = transactionCheckListener.checkLocalTransactionState(message);
- } else if (transactionListener != null) {
+ } else {
log.debug("Used new check API in transaction message");
localTransactionState = transactionListener.checkLocalTransaction(message);
- } else {
Review comment:
+1. Just leave the 'default' branch here may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org