You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/31 11:09:50 UTC
[GitHub] [spark] ivoson opened a new pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
ivoson opened a new pull request #32713:
URL: https://github.com/apache/spark/pull/32713
### What changes were proposed in this pull request?
Handle Currying Product while serializing TreeNode to JSON. While processing [Product](https://github.com/apache/spark/blob/v3.1.2/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala#L820), we may get an assert error for cases like Currying Product because of the mismatch of sizes between field name and field values.
Fallback to use reflection to get all the values for constructor parameters when we meet such cases.
### Why are the changes needed?
Avoid throwing error while serializing TreeNode to JSON, try to output as much information as possible.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New UT case added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson commented on pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #32713:
URL: https://github.com/apache/spark/pull/32713#issuecomment-851538084
Thanks for reviewing. @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32713:
URL: https://github.com/apache/spark/pull/32713#issuecomment-851520194
thanks, merging to master/3.1!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson edited a comment on pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
Posted by GitBox <gi...@apache.org>.
ivoson edited a comment on pull request #32713:
URL: https://github.com/apache/spark/pull/32713#issuecomment-851419481
Hit a [failed UT](https://github.com/apache/spark/blob/branch-2.4/sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala#L491) which would handle [CachedRDDBuilder](https://github.com/apache/spark/blob/branch-2.4/sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala#L45) after backporting https://github.com/apache/spark/pull/32557 to spark 2.4.
Have not came up with any cases in Spark 3, this is just in case. cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32713:
URL: https://github.com/apache/spark/pull/32713#issuecomment-851436300
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson edited a comment on pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
Posted by GitBox <gi...@apache.org>.
ivoson edited a comment on pull request #32713:
URL: https://github.com/apache/spark/pull/32713#issuecomment-851419481
Hit a [failed UT](https://github.com/apache/spark/blob/branch-2.4/sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala#L491) which would handle [CachedRDDBuilder](https://github.com/apache/spark/blob/branch-2.4/sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala#L45) after backporting https://github.com/apache/spark/pull/32557 to spark 2.4.
Have not came up with any cases in Spark 3.0, this is just in case. cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson commented on pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #32713:
URL: https://github.com/apache/spark/pull/32713#issuecomment-851419481
Hit a [failed UT](https://github.com/apache/spark/blob/branch-2.4/sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala#L491) which woudl handle [CachedRDDBuilder](https://github.com/apache/spark/blob/branch-2.4/sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala#L45) after backporting https://github.com/apache/spark/pull/32557 to spark 2.4.
Have not came up with any cases in Spark 3.0, this is just in case. cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32713:
URL: https://github.com/apache/spark/pull/32713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org