You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2026/06/03 15:25:56 UTC
Re: [PR] [GLUTEN-12225][CORE] Fix arrow.c shading: exclude memory/vector packages so public API stays unshaded [gluten]
zhztheplayer commented on code in PR #12226:
URL: https://github.com/apache/gluten/pull/12226#discussion_r3349770721
##########
package/pom.xml:
##########
@@ -121,10 +121,22 @@
<relocation>
<pattern>org.apache.arrow</pattern>
<shadedPattern>${gluten.shade.packageName}.org.apache.arrow</shadedPattern>
- <!--arrow's C and dataset wrapper refers to the original class path, so we should not relocate here-->
+ <!--
+ arrow's C and dataset wrappers refer to the original class
+ path, so they must not be relocated. Their public APIs also
+ take and return org.apache.arrow.memory.* and
+ org.apache.arrow.vector.* types, so those packages must also
+ stay unshaded — otherwise the bundled (unshaded)
+ ArrowArrayStream/ArrowSchema get compiled against the
+ relocated BufferAllocator/VectorSchemaRoot, producing
+ `NoSuchMethodError` for any caller passing a vanilla
+ Apache Arrow allocator. See #12225.
+ -->
<excludes>
<exclude>org.apache.arrow.c.*</exclude>
<exclude>org.apache.arrow.c.jni.*</exclude>
+ <exclude>org.apache.arrow.memory.**</exclude>
+ <exclude>org.apache.arrow.vector.**</exclude>
Review Comment:
nit: Should we directly exclude all arrow packages? E.g., `org.apache.arrow.*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org