[GitHub] [druid] clintropolis commented on pull request #10063: Fix HyperUniquesAggregatorFactory.estimateCardinality null handling to respect output type

[GitBox <gi...@apache.org>]

clintropolis commented on pull request #10063:
URL: https://github.com/apache/druid/pull/10063#issuecomment-648509082


   >FWIW I like that the result type will be consistent after this change, and I can't think of any computations going awry if the returned value is 0d instead of 0L
   
   I consider the existing behavior a bug, it should have always been respecting the output type. Using one of the tests that had to change, it didn't really make sense that null handling mode should change the output type.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org