You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "shriVATSA54 (via GitHub)" <gi...@apache.org> on 2023/10/01 10:41:11 UTC
[GitHub] [rocketmq] shriVATSA54 opened a new pull request, #7420: Enhancement/change method name/issue7313
shriVATSA54 opened a new pull request, #7420:
URL: https://github.com/apache/rocketmq/pull/7420
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### issue=> #7313
https://github.com/apache/rocketmq/issues/7313 This is link for my issue.
Fixes #7313
### Brief Description
There was an Enhancement change needed to change method name from addTopicToWhiteList of this TieredStoreTopicBlackListFilter class should be renamed to addTopicToBlackList .
In three places it was required to change the name which I have done.
**Note: This was my first ever contributions if you need some changes or if I committed mistake please do say and give feedback**
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
I have tried running the file and are running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 7313] Enhancement Optimization Method name [rocketmq]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7420:
URL: https://github.com/apache/rocketmq/pull/7420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 7313] Enhancement Optimization Method name [rocketmq]
Posted by "shriVATSA54 (via GitHub)" <gi...@apache.org>.
shriVATSA54 commented on PR #7420:
URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1748894522
> LGTM
Will it be merged ??
Should I keep contributing to some other issues too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] joeCarf commented on pull request #7420: Enhancement Optimization Method Name #7313
Posted by "joeCarf (via GitHub)" <gi...@apache.org>.
joeCarf commented on PR #7420:
URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1742439061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 7313] Enhancement Optimization Method name [rocketmq]
Posted by "shriVATSA54 (via GitHub)" <gi...@apache.org>.
shriVATSA54 commented on PR #7420:
URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1742692716
> for your reference, the title should be like the pic I paste above
Oh Sorry!
Made changes once again.
(Thank you My first ever Contribution)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 7313] Enhancement Optimization Method name [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7420:
URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1751533584
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7420](https://app.codecov.io/gh/apache/rocketmq/pull/7420?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d5e9cea) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/4f1b42a7c5557bcadd6b9982a0c9bd876622c69e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4f1b42a) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #7420 +/- ##
=============================================
- Coverage 42.62% 42.61% -0.01%
+ Complexity 9466 9465 -1
=============================================
Files 1150 1150
Lines 82758 82758
Branches 10779 10779
=============================================
- Hits 35272 35271 -1
- Misses 43062 43072 +10
+ Partials 4424 4415 -9
```
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...tore/provider/TieredStoreTopicBlackListFilter.java](https://app.codecov.io/gh/apache/rocketmq/pull/7420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL3Byb3ZpZGVyL1RpZXJlZFN0b3JlVG9waWNCbGFja0xpc3RGaWx0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7420/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] shriVATSA54 commented on pull request #7420: Enhancement Optimization Method Name #7313
Posted by "shriVATSA54 (via GitHub)" <gi...@apache.org>.
shriVATSA54 commented on PR #7420:
URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1742418362
> you can change the title like `[ISSUE #xxxx]xxxxx`
As per your request I have made changes in Title.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 7313] Enhancement Optimization Method name [rocketmq]
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #7420:
URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1749876913
> > LGTM
>
> Will it be merged ??
>
> Should I keep contributing to some other issues too?
> > LGTM
>
> Will it be merged ??
>
> Should I keep contributing to some other issues too?
Wait for a committer or PMC to merge the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org