You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Eli Reisman (JIRA)" <ji...@apache.org> on 2012/06/22 23:48:42 UTC
[jira] [Created] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Eli Reisman created GIRAPH-217:
----------------------------------
Summary: Add SimpleTriangleClosingVertex to Giraph examples
Key: GIRAPH-217
URL: https://issues.apache.org/jira/browse/GIRAPH-217
Project: Giraph
Issue Type: Bug
Components: examples
Reporter: Eli Reisman
Assignee: Eli Reisman
Priority: Trivial
Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: GIRAPH-217-3.patch
fixed comment ;)
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-1.patch, GIRAPH-217-2.patch, GIRAPH-217-3.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: GIRAPH-217-2.patch
small change, still need to try on cluster, but passes mvn verify.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Attachments: GIRAPH-217-1.patch, GIRAPH-217-2.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403375#comment-13403375 ]
Hudson commented on GIRAPH-217:
-------------------------------
Integrated in Giraph-trunk-Commit #125 (See [https://builds.apache.org/job/Giraph-trunk-Commit/125/])
GIRAPH-217. Add SimpleTriangleClosingVertex to Giraph examples. Contributed by Eli Reisman. (Revision 1355113)
Result = SUCCESS
jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355113
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleTriangleClosingVertex.java
* /giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingVertexTest.java
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-5.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400762#comment-13400762 ]
Jakob Homan commented on GIRAPH-217:
------------------------------------
Overall, looks good. Review:
* Rather than recommending a specific in/output format, how about describing the expected structure of the graph and then recommending those formats?
* Please describe what the algorith does in the javadoc, its input and final output state
* It'd be good to have a lots of javadoc explaining the algorithm so that new users can follow along easily
* Unit tests
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-1.patch, GIRAPH-217-2.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401650#comment-13401650 ]
Eli Reisman commented on GIRAPH-217:
------------------------------------
sorry, I meant "the test and the vertex build fine, the tests just don't pass yet" and I'm not sure if its my implementation of them (1st time using Mockito) or the algo is broken, suspect the former at this point but who knows...will ask advice and fix this ASAP.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-1.patch, GIRAPH-217-2.patch, GIRAPH-217-3.patch, GIRAPH-217-4.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: (was: GIRAPH-217-2.patch)
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-5.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: (was: GIRAPH-217-1.patch)
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-5.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: GIRAPH-217-4.patch
explanation of algorithm in comments was added, along with unit/integration test. passes mvn verify for build, but the tests need to get fixed still. Just a placeholder, but almost done...got other work to do, will come back to this.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-1.patch, GIRAPH-217-2.patch, GIRAPH-217-3.patch, GIRAPH-217-4.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: GIRAPH-217-5.patch
Passes 'mvn verify', includes explanation of algorithm in comments, includes unit and integration tests.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-5.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400980#comment-13400980 ]
Eli Reisman commented on GIRAPH-217:
------------------------------------
ok, I'll get on that and submit another patch
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-1.patch, GIRAPH-217-2.patch, GIRAPH-217-3.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: GIRAPH-217-1.patch
This passes mvn verify, will test on cluster ASAP, and probably add improvements soon, this is the basic vanilla version.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Attachments: GIRAPH-217-1.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: (was: GIRAPH-217-4.patch)
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-5.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403372#comment-13403372 ]
Jakob Homan commented on GIRAPH-217:
------------------------------------
+1. Good job.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-5.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399820#comment-13399820 ]
Eli Reisman commented on GIRAPH-217:
------------------------------------
I'm going to attempt IntIntNullIntTextInputFormat and IdWithValueTextOutputFormat for testing, and maybe post a little unit test if these work with no trouble on a sample graph.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Attachments: GIRAPH-217-1.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated GIRAPH-217:
-------------------------------
Attachment: (was: GIRAPH-217-3.patch)
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-5.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-217) Add SimpleTriangleClosingVertex to
Giraph examples
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399638#comment-13399638 ]
Eli Reisman commented on GIRAPH-217:
------------------------------------
This will be I/O format agnostic, but whatever the input format it should amount to a simple, directed, unweighted graph with integer ID's per vertex and then a list out-edge values (also integer destination ID's); rinse and repeat for as many vertices as you want in the graph. Output should emit vertex ID and value only; the value will be an array of Writables ranked by frequency of in-msg during the message-gathering superstep.
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
>
> Very simple triangle closing vertex using ID values, mostly for scale testing purposes, same as PR and shortest paths vertex examples. Might get fancier at a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira