[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19782: [fix][broker] Fix admin api status code compatibility

["michaeljmarshall (via GitHub)" <gi...@apache.org>]

michaeljmarshall commented on code in PR #19782:
URL: https://github.com/apache/pulsar/pull/19782#discussion_r1134090357


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -420,7 +420,7 @@ protected CompletableFuture<Void> internalCreateNonPartitionedTopicAsync(boolean
             .thenCompose(partitionedTopicMetadata -> {
                 int currentMetadataPartitions = partitionedTopicMetadata.partitions;
                 if (currentMetadataPartitions <= 0) {
-                    throw new RestException(422 /* Unprocessable entity*/,
+                    throw new RestException(Status.CONFLICT /* Unprocessable entity*/,

Review Comment:
   @mattisonchao - the Javadoc for this method and for the methods that call it are now out of sync. Would you mind following up and updating them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org