[GitHub] csantanapr commented on issue #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox <gi...@apache.org>]

csantanapr commented on issue #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests
URL: https://github.com/apache/incubator-openwhisk/pull/3616#issuecomment-386845240
 
 
   @jonpspri check this PR, travis is has errors.
   
   In addition I tried this PR locally, in docker for Mac, where it's fine to run `docker run` with no host `--host specified`
   
   I deleted the whisk.properties and try to run the test for the runtime-nodejs runtime
   ```
   😄  $ rm $OPENWHISK_HOME/whisk.properties
   ~/dev/whisk/git/apache/incubator-openwhisk-runtime-nodejs (master)
   🔥  $ cat OPENWHISK_HOME/whisk.properties
   cat: $OPENWHISK_HOMEwhisk.properties: No such file or directory
   ~/dev/whisk/git/apache/incubator-openwhisk-runtime-nodejs (master)
   🍰  $ ./gradlew tests:test
   
   > Task :tests:compileTestScala
   Pruning sources from previous analysis, due to incompatible CompileSetup.
   
   > Task :tests:test
   
   runtime.actionContainers.NodeJs6ActionContainerTests STANDARD_OUT
       [2018-05-05T20:36:50.788Z] [INFO] Slf4jLogger started
   
   runtime.actionContainers.NodeJs6ActionContainerTests > nodejs6action should run and report an error for script not returning a json object FAILED
       java.lang.AssertionError: '/Users/csantana23/dev/whisk/git/apache/incubator-openwhisk/whisk.properties' does not exists but required
   
   runtime.actionContainers.NodeJs6ActionContainerTests > nodejs6action should run a node script FAILED
       java.lang.NoClassDefFoundError: Could not initialize class common.WhiskProperties
   
   runtime.actionContainers.NodeJs8ActionContainerTests STANDARD_OUT
       [2018-05-05T20:36:51.069Z] [INFO] Slf4jLogger started
   
   runtime.actionContainers.NodeJs8ActionContainerTests > action-nodejs-v8 should run and report an error for script not returning a json object FAILED
       java.lang.NoClassDefFoundError: Could not initialize class common.WhiskProperties
   
   3 tests completed, 3 failed
   ```
   It looks like something still depends on whisk.properties

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services