You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/08 16:05:42 UTC
[GitHub] [hive] saihemanth-cloudera commented on a diff in pull request #3105: [WIP]HIVE-21456: Thrift over Http for Hive Metastore
saihemanth-cloudera commented on code in PR #3105:
URL: https://github.com/apache/hive/pull/3105#discussion_r846281556
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java:
##########
@@ -437,15 +439,36 @@ public void testConnectionWrongCertCN() throws Exception {
* Test HMS server with SSL
* @throws Exception
*/
+ @Ignore
@Test
public void testMetastoreWithSSL() throws Exception {
testSSLHMS(true);
}
+ /**
+ * Test HMS server with Http + SSL
+ * @throws Exception
+ */
+ @Test
+ public void testMetastoreWithHttps() throws Exception {
+ // MetastoreConf.setBoolVar(conf, MetastoreConf.ConfVars.EVENT_DB_NOTIFICATION_API_AUTH, false);
+ //MetastoreConf.setVar(conf, MetastoreConf.ConfVars.METASTORE_CLIENT_TRANSPORT_MODE, "http");
+ SSLTestUtils.setMetastoreHttpsConf(conf);
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_TRUSTMANAGERFACTORY_ALGORITHM,
+ KEY_MANAGER_FACTORY_ALGORITHM);
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_TRUSTSTORE_TYPE, KEY_STORE_TRUST_STORE_TYPE);
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_KEYSTORE_TYPE, KEY_STORE_TRUST_STORE_TYPE);
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_KEYMANAGERFACTORY_ALGORITHM,
+ KEY_MANAGER_FACTORY_ALGORITHM);
+
+ testSSLHMS(false);
Review Comment:
Why are we passing false here? This value is used in testSSLHMS()#L459-461 to set the keystore for HMS and HS2. You are already setting this for HMS in L461 here and we don't need to set for HS2. So why don't we just pass the value true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org