You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Mark Koudritsky <ka...@gmail.com> on 2014/01/27 21:20:56 UTC
Review Request 17417: Change to --link-to and --copy-from instead of --src
and --link
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17417/
-----------------------------------------------------------
Review request for cordova.
Bugs: CB-4153
https://issues.apache.org/jira/browse/CB-4153
Repository: cordova-cli
Description
-------
Change to --link-to and --copy-from instead of --src and --link for better clarity.
Diffs
-----
src/cli.js c45b556
Diff: https://reviews.apache.org/r/17417/diff/
Testing
-------
npm test
cordova create tst --copy-from=...
cordova create tst --link-to=...
cordova prepare
Thanks,
Mark Koudritsky
Re: Review Request 17417: Change to --link-to and --copy-from instead of
--src and --link
Posted by Andrew Grieve <ag...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17417/#review33343
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Grieve
On Jan. 31, 2014, 4:12 p.m., Mark Koudritsky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17417/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 4:12 p.m.)
>
>
> Review request for cordova.
>
>
> Bugs: CB-4153
> https://issues.apache.org/jira/browse/CB-4153
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> Change to --link-to and --copy-from instead of --src and --link for better clarity.
>
>
> Diffs
> -----
>
> src/cli.js c45b556
>
> Diff: https://reviews.apache.org/r/17417/diff/
>
>
> Testing
> -------
>
> npm test
> cordova create tst --copy-from=...
> cordova create tst --link-to=...
> cordova prepare
>
>
> Thanks,
>
> Mark Koudritsky
>
>
Re: Review Request 17417: Change to --link-to and --copy-from instead
of --src and --link
Posted by Andrew Grieve <ag...@chromium.org>.
merged.
On Fri, Jan 31, 2014 at 11:12 AM, Mark Koudritsky <ka...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17417/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 4:12 p.m.)
>
>
> Review request for cordova.
>
>
> Changes
> -------
>
> Added back the --src as alias to --compy-from
>
>
> Bugs: CB-4153
> https://issues.apache.org/jira/browse/CB-4153
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> Change to --link-to and --copy-from instead of --src and --link for
> better clarity.
>
>
> Diffs (updated)
> -----
>
> src/cli.js c45b556
>
> Diff: https://reviews.apache.org/r/17417/diff/
>
>
> Testing
> -------
>
> npm test
> cordova create tst --copy-from=...
> cordova create tst --link-to=...
> cordova prepare
>
>
> Thanks,
>
> Mark Koudritsky
>
>
Re: Review Request 17417: Change to --link-to and --copy-from instead of
--src and --link
Posted by Mark Koudritsky <ka...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17417/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 4:12 p.m.)
Review request for cordova.
Changes
-------
Added back the --src as alias to --compy-from
Bugs: CB-4153
https://issues.apache.org/jira/browse/CB-4153
Repository: cordova-cli
Description
-------
Change to --link-to and --copy-from instead of --src and --link for better clarity.
Diffs (updated)
-----
src/cli.js c45b556
Diff: https://reviews.apache.org/r/17417/diff/
Testing
-------
npm test
cordova create tst --copy-from=...
cordova create tst --link-to=...
cordova prepare
Thanks,
Mark Koudritsky