You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/05 06:35:12 UTC
[GitHub] [flink] fredia opened a new pull request, #20160: [FLINK-28286] move 'enablechangelog' constant to flink-core module
fredia opened a new pull request, #20160:
URL: https://github.com/apache/flink/pull/20160
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Some methods in the `flink-runtime` module want to use `StreamConfig.ENABLE_CHANGE_LOG_STATE_BACKEND `constant(in `flink-streaming-java` module), but `flink-runtime` should not depend on `flink-streaming-java`. This pr moves the changelog flag to `flink-core`.
See this [discussion](https://github.com/apache/flink/pull/19907#discussion_r902485780) for more details.
## Brief change log
- move `ENABLE_CHANGE_LOG_STATE_BACKEND` from `StreamConfig` to `org.apache.flink.api.common.ExecutionConfig`
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes,`org.apache.flink.api.common.ExecutionConfig` )
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r918891658
##########
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/BootstrapTransformation.java:
##########
@@ -232,8 +231,6 @@ StreamConfig getConfig(
config.setOperatorName(operatorID.toHexString());
config.setOperatorID(operatorID);
config.setStateBackend(stateBackend);
- // This means leaving this stateBackend unwrapped.
- config.setChangelogStateBackendEnabled(TernaryBoolean.FALSE);
Review Comment:
why is this removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r918893334
##########
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/BootstrapTransformation.java:
##########
@@ -232,8 +231,6 @@ StreamConfig getConfig(
config.setOperatorName(operatorID.toHexString());
config.setOperatorID(operatorID);
config.setStateBackend(stateBackend);
- // This means leaving this stateBackend unwrapped.
- config.setChangelogStateBackendEnabled(TernaryBoolean.FALSE);
Review Comment:
Aha, it's now directly encoded into the job configuration by the SavepointEnvironment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r918841799
##########
flink-core/src/main/java/org/apache/flink/configuration/StateChangelogOptionsInternal.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.util.FlinkRuntimeException;
+import org.apache.flink.util.InstantiationUtil;
+import org.apache.flink.util.TernaryBoolean;
+
+/** StateChangelog options that are used to pass job-level configuration from JM to TM. */
+@Internal
+public class StateChangelogOptionsInternal {
Review Comment:
This seems overly complicated. Why aren't you using `Configuration#getOptional`, with a proper `ConfigOption<Boolean>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #20160: [FLINK-28286] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r915792964
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -138,6 +139,8 @@ public class ExecutionConfig implements Serializable, Archiveable<ArchivedExecut
private boolean isLatencyTrackingConfigured = false;
+ private TernaryBoolean changelogEnabled = TernaryBoolean.UNDEFINED;
+
Review Comment:
The `periodicMaterializeIntervalMillis` and `materializationMaxAllowedFailures` associated with changelog are also in `ExecutionConfig`, and I can't find a good class or a new class to put the constants (and the parsing code) in `flink-core`. So I prefer to put it to `ExecutionConfig`, do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #20160:
URL: https://github.com/apache/flink/pull/20160#issuecomment-1181335690
Sure, Rebased. Thanks a lot for your review and patience!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r918841799
##########
flink-core/src/main/java/org/apache/flink/configuration/StateChangelogOptionsInternal.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.util.FlinkRuntimeException;
+import org.apache.flink.util.InstantiationUtil;
+import org.apache.flink.util.TernaryBoolean;
+
+/** StateChangelog options that are used to pass job-level configuration from JM to TM. */
+@Internal
+public class StateChangelogOptionsInternal {
Review Comment:
This seems overly complicated. Why aren't you using `Configuration#getOptional`, with a proper `ConfigOption<Boolean>`, instead of the `InstantiationUtil` business?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged PR #20160:
URL: https://github.com/apache/flink/pull/20160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a diff in pull request #20160: [FLINK-28286] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r915780409
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -138,6 +139,8 @@ public class ExecutionConfig implements Serializable, Archiveable<ArchivedExecut
private boolean isLatencyTrackingConfigured = false;
+ private TernaryBoolean changelogEnabled = TernaryBoolean.UNDEFINED;
+
Review Comment:
I meant making `JobInformation.jobConfiguration` the **container** for changelog configuration; but having the constants (and the parsing code) in `flink-core`. That would be similar to `DistributedCache`.
`BootstrapTransformation` would be able to access the config too.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20160: [FLINK-28286] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20160:
URL: https://github.com/apache/flink/pull/20160#issuecomment-1174677469
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17e0815b240a40f17b7eeb523d2c24068c3b61ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17e0815b240a40f17b7eeb523d2c24068c3b61ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17e0815b240a40f17b7eeb523d2c24068c3b61ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #20160: [FLINK-28286] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r914358528
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -138,6 +139,8 @@ public class ExecutionConfig implements Serializable, Archiveable<ArchivedExecut
private boolean isLatencyTrackingConfigured = false;
+ private TernaryBoolean changelogEnabled = TernaryBoolean.UNDEFINED;
+
Review Comment:
Yes, but there are two things to consider:
1. `JobInformation` is in `flink-runtime` module. Moving the configuration to `JobInformation.jobConfiguration` is not much different from the [current situation](https://github.com/apache/flink/pull/19907#discussion_r902485780) (`changelogEnabled ` is in `TaskInformation.taskConfiguration`). Do you mean moving the parsing to `JobInformation`? something like:
```java
public class JobInformation implements Serializable {
private static final String ENABLE_CHANGE_LOG_STATE_BACKEND = "enablechangelog";
/** Configuration of the job. */
private final Configuration jobConfiguration;
...
public void setChangelogStateBackendEnabled(TernaryBoolean enabled) {
try {
InstantiationUtil.writeObjectToConfig(
enabled, this.jobConfiguration, ENABLE_CHANGE_LOG_STATE_BACKEND);
} catch (Exception e) {
throw new StreamTaskException(
"Could not serialize change log state backend enable flag.", e);
}
}
public TernaryBoolean isChangelogStateBackendEnabled(ClassLoader cl) {
try {
return InstantiationUtil.readObjectFromConfig(
this.jobConfiguration, ENABLE_CHANGE_LOG_STATE_BACKEND, cl);
} catch (Exception e) {
throw new StreamTaskException(
"Could not instantiate change log state backend enable flag.", e);
}
}
...
}
```
2. `BootstrapTransformation` in `flink-state-processing-api` also needs `enablechangelog` configuration, if move it to `JobInformation.jobConfiguration`, do we need to keep a copy of this configuration in `flink-streaming-java`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #20160: [FLINK-28286] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r915792964
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -138,6 +139,8 @@ public class ExecutionConfig implements Serializable, Archiveable<ArchivedExecut
private boolean isLatencyTrackingConfigured = false;
+ private TernaryBoolean changelogEnabled = TernaryBoolean.UNDEFINED;
+
Review Comment:
The `periodicMaterializeIntervalMillis` and `materializationMaxAllowedFailures` associated with changelog are also in `ExecutionConfig`, and I can't find a good class or a new class to put the constants (and the parsing code) in `flink-core`, do you have any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r918930181
##########
flink-core/src/main/java/org/apache/flink/configuration/StateChangelogOptionsInternal.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.util.FlinkRuntimeException;
+import org.apache.flink.util.InstantiationUtil;
+import org.apache.flink.util.TernaryBoolean;
+
+/** StateChangelog options that are used to pass job-level configuration from JM to TM. */
+@Internal
+public class StateChangelogOptionsInternal {
Review Comment:
Thanks for your suggestion, I have refactored it with `ConfigOption<Boolean>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a diff in pull request #20160: [FLINK-28286] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r914201840
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java:
##########
@@ -199,6 +199,7 @@ public StateBackend getStateBackend() {
public void setChangelogStateBackendEnabled(TernaryBoolean changelogStateBackendEnabled) {
this.changelogStateBackendEnabled = changelogStateBackendEnabled;
+ this.executionConfig.setChangelogStateBackendEnabled(changelogStateBackendEnabled);
Review Comment:
I think `changelogStateBackendEnabled` field is unnecessary now and its read can be replaced with `executionConfig.isChangelogStateBackendEnabled()`.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -138,6 +139,8 @@ public class ExecutionConfig implements Serializable, Archiveable<ArchivedExecut
private boolean isLatencyTrackingConfigured = false;
+ private TernaryBoolean changelogEnabled = TernaryBoolean.UNDEFINED;
+
Review Comment:
Have you considered moving the configuration to `JobInformation.jobConfiguration` instead of `ExecutionConfig`?
I think it would be easier for
- FLINK-26372 because `StateChangelogStorageFactory` requires multiple parameters
- and probably for FLINK-27692 if there will be more conifg parameters
WDYT?
cc: @zoltar9264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r915792964
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -138,6 +139,8 @@ public class ExecutionConfig implements Serializable, Archiveable<ArchivedExecut
private boolean isLatencyTrackingConfigured = false;
+ private TernaryBoolean changelogEnabled = TernaryBoolean.UNDEFINED;
+
Review Comment:
I have moved the constants (and the parsing code) to `StateChangelogOption` and put it into `JobInformation.jobConfiguration`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20160: [FLINK-28286][state] move 'enablechangelog' constant to flink-core module
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20160:
URL: https://github.com/apache/flink/pull/20160#discussion_r918841799
##########
flink-core/src/main/java/org/apache/flink/configuration/StateChangelogOptionsInternal.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.util.FlinkRuntimeException;
+import org.apache.flink.util.InstantiationUtil;
+import org.apache.flink.util.TernaryBoolean;
+
+/** StateChangelog options that are used to pass job-level configuration from JM to TM. */
+@Internal
+public class StateChangelogOptionsInternal {
Review Comment:
This seems overly complicated. Why aren't you using `Configuration#getOptional`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org