You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/03 17:16:01 UTC

[GitHub] [skywalking-python] tom-pytel opened a new pull request #121: removed incorrect plugin sw_tornado5.py

tom-pytel opened a new pull request #121:
URL: https://github.com/apache/skywalking-python/pull/121


   <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
   <!--
   - [ ] Add a test case for the new plugin
   - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
   - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
   -->
   
   Removed sw_tornado5 for two reasons:
   
   1. A single line change does not justify a whole new plugin, it should be a check in a single plugin:
   ```
   <   peer = request.connection.stream.socket.getpeername()
   <   span.peer = '{0}:{1}'.format(*peer)
   ---
   >   span.peer = request.host
   ```
   
   2. This single line change is incorrect, `request.host` gives the address where the server is serving, not the client peer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] tom-pytel merged pull request #121: removed incorrect plugin sw_tornado5.py

Posted by GitBox <gi...@apache.org>.
tom-pytel merged pull request #121:
URL: https://github.com/apache/skywalking-python/pull/121


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] tom-pytel merged pull request #121: removed incorrect plugin sw_tornado5.py

Posted by GitBox <gi...@apache.org>.
tom-pytel merged pull request #121:
URL: https://github.com/apache/skywalking-python/pull/121


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org