You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/10/19 03:51:52 UTC

[PR] fix(ai): ignore stop errors after the owned run ends [rocketmq-dashboard]

Aias00 opened a new pull request, #7000:
URL: https://github.com/apache/rocketmq-dashboard/pull/7000

   ### Which Issue(s) This PR Fixes
   
   Fixes #6995
   
   ### Brief Description
   
   Track the terminal/closed state of the owned run separately from request ownership. A delayed Stop rejection must not overwrite a completed run or replace its stream failure. Navigation and new-stream guards remain unchanged, as do failures while the run is active.
   
   ### How Did You Test This Change?
   
   - Three deterministic regressions failed on baseline: terminal frame before rejection, normal close before rejection, failed stream before rejection.
   - `npm test -- src/pages/ai/hooks`: 7 files, 60 tests passed, including active Stop failure and request ownership cases.
   - Changed-file ESLint, Prettier and `git diff --check` passed.
   - `npx tsc -b` and `npm run build` passed (including license check).
   - Full repository tests not rerun locally for this isolated change; CI will run them.
   
   ### Checklist
   
   - [x] One coherent change
   - [x] Conventional commit subject
   - [x] Regression tests use ...Test names
   - [x] No new dependencies, UI copy, wire changes or files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ai): ignore stop errors after the owned run ends [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #7000: fix(ai): ignore stop errors after the owned run ends
URL: https://github.com/apache/rocketmq-dashboard/pull/7000


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ai): ignore stop errors after the owned run ends [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #7000:
URL: https://github.com/apache/rocketmq-dashboard/pull/7000#issuecomment-6448367611

   Merged as part of #7207 - squashed into `rocketmq-studio` as `fe44f3a47`.
   
   Your change here (swallowing a stop-request failure once the run it belonged to has already ended, and clearing `stopRequested` before that early return so the composer does not stay stuck in the stopping state. Both points the review raised are in: the flag is reset ahead of the guard, and there is now an assertion that the state is not stuck after `run_finished`.) is included.
   
   We grouped 2 of your related fixes into a single commit so the trunk history stays reviewable; the other PR in the group is closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change. The combined branch was verified against the full backend and frontend suites, the license gate, the type check and lint before merging.
   
   Thanks for the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org