You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/12 01:42:20 UTC
[GitHub] [beam] chamikaramj opened a new pull request #13536: [BEAM-11360] Updates Dataflow Python multi-language pipelines to use portable job submission by default
chamikaramj opened a new pull request #13536:
URL: https://github.com/apache/beam/pull/13536
Also cleans up multi-language pipelines related hooks in Python SDK that are not needed when we use portable job submission (hence directly generate Dataflow steps from the Runner API proto).
These hooks were mostly were added in PRs https://github.com/apache/beam/pull/8270 and https://github.com/apache/beam/pull/11185.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #13536: [BEAM-11360] Updates Dataflow Python multi-language pipelines to use portable job submission by default
Posted by GitBox <gi...@apache.org>.
chamikaramj merged pull request #13536:
URL: https://github.com/apache/beam/pull/13536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #13536: [BEAM-11360] Updates Dataflow Python multi-language pipelines to use portable job submission by default
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #13536:
URL: https://github.com/apache/beam/pull/13536#discussion_r543659576
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -509,19 +514,25 @@ def run(self, test_runner_api='AUTO'):
self.runner.__class__.__name__ == 'SwitchingDirectRunner' and
not self._options.view_as(StandardOptions).streaming)
+ # Multi-language pipelines that contain external pipeline segments may
+ # not be able to create a Python pipeline object graph. Hence following
+ # runner API check should be skipped for such pipelines.
+ external_transform_finder = ExternalTransformFinder()
+ self.visit(external_transform_finder)
Review comment:
This was redundant. Updated.
Also, updated the visitor class by adding a static method like you mentioned.
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -580,6 +533,11 @@ def run_pipeline(self, pipeline, options):
debug_options.add_experiment(
'min_cpu_platform=' + worker_options.min_cpu_platform)
+ if pipeline.contains_external_transforms:
+ # All Dataflow multi-language pipelines use portable job submission by
+ # default.
+ debug_options.add_experiment("use_portable_job_submission")
Review comment:
Yes, updated to also include a Runner v2 check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13536: [BEAM-11360] Updates Dataflow Python multi-language pipelines to use portable job submission by default
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13536:
URL: https://github.com/apache/beam/pull/13536#issuecomment-743622744
R: @robertwb @ihji
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a change in pull request #13536: [BEAM-11360] Updates Dataflow Python multi-language pipelines to use portable job submission by default
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #13536:
URL: https://github.com/apache/beam/pull/13536#discussion_r542977576
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -509,19 +514,25 @@ def run(self, test_runner_api='AUTO'):
self.runner.__class__.__name__ == 'SwitchingDirectRunner' and
not self._options.view_as(StandardOptions).streaming)
+ # Multi-language pipelines that contain external pipeline segments may
+ # not be able to create a Python pipeline object graph. Hence following
+ # runner API check should be skipped for such pipelines.
+ external_transform_finder = ExternalTransformFinder()
+ self.visit(external_transform_finder)
Review comment:
Don't we have to do something with external_transform_finder.contains_external_transforms? (Or is this fully redundant with the statement above?)
(IMHO, this visitor pattern is a bit error-prone, perhaps it'd be worth a static method on ExternalTransformFinder that does the visiting and returns a boolean.)
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -580,6 +533,11 @@ def run_pipeline(self, pipeline, options):
debug_options.add_experiment(
'min_cpu_platform=' + worker_options.min_cpu_platform)
+ if pipeline.contains_external_transforms:
+ # All Dataflow multi-language pipelines use portable job submission by
+ # default.
+ debug_options.add_experiment("use_portable_job_submission")
Review comment:
Just to check, this implies runner v2, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org