You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/16 09:23:30 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue #7482: Add CircuitBreak function for PostgreSQL proxy
terrymanu opened a new issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482
Please FIY MySQL proxy's implementation on `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] victorzhangchn edited a comment on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
victorzhangchn edited a comment on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-695923046
> Please FIY MySQL proxy's implementation on `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor`
I'm confusing that the code about CircuitBreak in both `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor` is just throw CircuitBreakException, and then wrap it at the outer layer. What do you actually want me to do in this issue? Just throw CircuitBreakException in `PostgreSQLComExecuteExecutor` and `PostgreSQLComQueryExecutor`? By the way, I find that the behaviour of `PostgreSQLComBindExecutor` does not match the command `BIND` of protocol of PostgreSQL. @menghaoranss @terrymanu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] victorzhangchn commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
victorzhangchn commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-695923046
> Please FIY MySQL proxy's implementation on `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor`
I'm confusing that the code about CircuitBreak in both `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor` is just throw CircuitBreakException, and then wrap it at the outer layer. What do you actually want me to do in this issue? Just throw CircuitBreakException in `PostgreSQLComExecuteExecutor` and `PostgreSQLComQueryExecutor`? By the way, I find that the behaviour of `PostgreSQLComBindExecutor` does not match the command `BIND` of protocol of PostgreSQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-857620417
@SamuelJohnson01997 You are correct, the feature is finished, I just close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] SamuelJohnson01997 commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
SamuelJohnson01997 commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-753438795
Hi @terrymanu, this issue is still open? If so, I would be glad to help. Kindly assign the issue to me. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] victorzhangchn commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
victorzhangchn commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-695923046
> Please FIY MySQL proxy's implementation on `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor`
I'm confusing that the code about CircuitBreak in both `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor` is just throw CircuitBreakException, and then wrap it at the outer layer. What do you actually want me to do in this issue? Just throw CircuitBreakException in `PostgreSQLComExecuteExecutor` and `PostgreSQLComQueryExecutor`? By the way, I find that the behaviour of `PostgreSQLComBindExecutor` does not match the command `BIND` of protocol of PostgreSQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] SamuelJohnson01997 commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
SamuelJohnson01997 commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-788219266
Hi @terrymanu, after this https://github.com/apache/shardingsphere/commit/89cc0a08c824daf67c88e6cbabaaa05f79886d06 commit, I think the CircuitBreak is moved as state and thus the respective code in MySQLComStmtExecuteExecutor and MySQLComQueryPacketExecutor is removed in the same commit. Should we be still adding the throwing part in PostgreSQLComExecuteExecutor and PostgreSQLComQueryExecutor or is this resolved already? Please guide me if I'm missing anything. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] victorzhangchn commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
victorzhangchn commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-693291889
Please assign to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-720463647
Yes, Just throw CircuitBreakException in PostgreSQLComExecuteExecutor and PostgreSQLComQueryExecutor `if in CircuitBreak model`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] victorzhangchn edited a comment on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
victorzhangchn edited a comment on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-695923046
> Please FIY MySQL proxy's implementation on `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor`
I'm confusing that the code about CircuitBreak in both `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor` is just throw CircuitBreakException, and then wrap it at the outer layer. What do you actually want me to do in this issue? Just throw CircuitBreakException in `PostgreSQLComExecuteExecutor` and `PostgreSQLComQueryExecutor`? By the way, I find that the behaviour of `PostgreSQLComBindExecutor` does not match the command `BIND` of protocol of PostgreSQL. @menghaoranss @terrymanu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #7482: Add CircuitBreak function for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-787925878
@SamuelJohnson01997
Hi Samuel, it still open, please have a look, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org