You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datalab.apache.org by yt...@apache.org on 2021/06/04 08:35:51 UTC
[incubator-datalab] branch DATALAB-2387 created (now a7003d3)
This is an automated email from the ASF dual-hosted git repository.
ytykhun pushed a change to branch DATALAB-2387
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git.
at a7003d3 [DATALAB-2387] fixed bug with installing libraries on Manage libraries pop up
This branch includes the following new commits:
new a7003d3 [DATALAB-2387] fixed bug with installing libraries on Manage libraries pop up
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org
[incubator-datalab] 01/01: [DATALAB-2387] fixed bug with installing
libraries on Manage libraries pop up
Posted by yt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ytykhun pushed a commit to branch DATALAB-2387
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git
commit a7003d3e2a32faa2d65048d72818a54a9389d2d2
Author: Yurii Tykhun <ty...@gmail.com>
AuthorDate: Fri Jun 4 11:35:24 2021 +0300
[DATALAB-2387] fixed bug with installing libraries on Manage libraries pop up
---
.../install-libraries/install-libraries.component.html | 8 ++++----
.../exploratory/install-libraries/install-libraries.component.ts | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
index 09eb859..7fe0d22 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
@@ -90,16 +90,16 @@
</div>
</mat-option>
</ng-template>
- <mat-option *ngIf="!filteredList?.length && !validity_format && autoComplete === 'ENABLED'">
+ <mat-option *ngIf="!filteredList?.length && !validity_format && autoComplete === 'ENABLED' && lib.name?.length > 0" disabled>
<span class="configuring">No matches found</span>
</mat-option>
<mat-option *ngIf="validity_format?.length > 0 && autoComplete === 'ENABLED'">
<span class="configuring" >{{ validity_format }}</span >
</mat-option>
- <mat-option *ngIf="autoComplete === 'NONE' && lib.name?.length > 1">
+ <mat-option *ngIf="autoComplete === 'NONE' && lib.name?.length > 1" disabled>
<span class="configuring" >Autocomplete is currently unavailable for {{groupsListMap[group]}} group</span >
</mat-option>
- <mat-option *ngIf="autoComplete === 'UPDATING' && lib.name?.length > 1">
+ <mat-option *ngIf="autoComplete === 'UPDATING' && lib.name?.length > 1" disabled>
<span class="configuring" >Library list is being loaded at the moment. Please wait a minute.</span>
</mat-option>
</mat-autocomplete>
@@ -112,7 +112,7 @@
class="library-input"
[placeholder]="'Enter library version (optional)'"
[(ngModel)]="lib.version"
- [disabled]="!lib.name.trim() || lib.name.trim().length < 2"
+ [disabled]="!lib.name?.trim() || lib.name?.trim().length < 2"
(keyup)="validateVersion(lib.version)"
(keydown.enter)="addLibrary(lib)"
>
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
index b97f583..1b44d99 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
@@ -112,7 +112,7 @@ export class InstallLibrariesComponent implements OnInit, OnDestroy {
takeUntil(this.unsubscribe$)
)
.subscribe(value => {
- if(!!value.match(/\s+/g)) {
+ if(!!value?.match(/\s+/g)) {
this.libSearch.setValue(value.replace(/\s+/g, ''))
this.lib.name = value.replace(/\s+/g, '');
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org