You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/15 18:21:56 UTC
[GitHub] [incubator-mxnet] stu1130 opened a new pull request #18070: [v1.7]
Backport #17702 and #17872 to v1.7 branch (#18038)
stu1130 opened a new pull request #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070
* Support projection feature for LSTM on CPU (Only Inference) (#17702)
* Support projection feature for LSTM on CPU
* test solution for -Werror=maybe-uninitialized
* Check device type when create state
* Document the projection feature of LSTM for RNN operator
* Minor fix
* Re-run CI
* Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1 (#17872)
* Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1
* Use nd.copy() to initialize parameters of new operator
* Add check for output states
* Initialize i2h/h2h_weights with zeros for rnn_relu/tanh, and reduce size
* Split fused rnn layer test into tests of individual mode
* Skip lstm and gru tests on CPU context without DNNL
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18070: [v1.7]
Backport #17702 and #17872 to v1.7 branch (#18038)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070#issuecomment-614201001
Hey @stu1130 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, centos-gpu, clang, windows-gpu, centos-cpu, unix-cpu, unix-gpu, edge, windows-cpu, miscellaneous, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #18070: [v1.7] Backport
#17702 and #17872 to v1.7 branch (#18038)
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070#issuecomment-614212250
Should this go to 1.x instead? https://lists.apache.org/thread.html/rca8c8a9ac11e24197b4ee536e8432dd97b67424b5ee2f31c68b2958c%40%3Cdev.mxnet.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] stu1130 commented on issue #18070: [v1.7]
Backport #17702 and #17872 to v1.7 branch (#18038)
Posted by GitBox <gi...@apache.org>.
stu1130 commented on issue #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070#issuecomment-614201743
@zixuanweeei I help you cherry-pick the commit to v1.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] stu1130 edited a comment on issue #18070: [v1.7]
Backport #17702 and #17872 to v1.7 branch (#18038)
Posted by GitBox <gi...@apache.org>.
stu1130 edited a comment on issue #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070#issuecomment-614213480
@leezu It is already in 1.x. We need the fix to build libmxnet temporarily
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] stu1130 closed pull request #18070: [v1.7]
Backport #17702 and #17872 to v1.7 branch (#18038)
Posted by GitBox <gi...@apache.org>.
stu1130 closed pull request #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] stu1130 commented on issue #18070: [v1.7]
Backport #17702 and #17872 to v1.7 branch (#18038)
Posted by GitBox <gi...@apache.org>.
stu1130 commented on issue #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070#issuecomment-614213480
@leezu It is already in 1.x. We need the fix to build temporarily libmxnet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] stu1130 commented on issue #18070: [v1.7]
Backport #17702 and #17872 to v1.7 branch (#18038)
Posted by GitBox <gi...@apache.org>.
stu1130 commented on issue #18070: [v1.7] Backport #17702 and #17872 to v1.7 branch (#18038)
URL: https://github.com/apache/incubator-mxnet/pull/18070#issuecomment-614215640
close the PR as Ciyong will sync up 1.7 with 1.x on 0417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services