You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/26 23:48:25 UTC

[GitHub] [pinot] ankitsultana commented on pull request #9461: Fix Data-Correctness Bug in GTE Comparison in BinaryOperatorTransformFunction

ankitsultana commented on PR #9461:
URL: https://github.com/apache/pinot/pull/9461#issuecomment-1258778744

   Added a UT. Existing tests weren't able to catch this case since this only happens when the argument types are:
   
   1. float, long
   2. double, long
   3. long, float
   4. long, double
   
   I also found a bug in my PR. I had only updated calls for one of the `compare` methods. Caught that bug via the UT I added 😓 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org