You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "kparzysz-quic (via GitHub)" <gi...@apache.org> on 2023/04/03 19:09:01 UTC

[GitHub] [tvm] kparzysz-quic opened a new pull request, #14470: [LLVM] Add missing `override` to GetFormat and GetPropertyMask

kparzysz-quic opened a new pull request, #14470:
URL: https://github.com/apache/tvm/pull/14470

   These functions are virtual, and some of the overrides were not marked as either `final` or `override` causing compilation warnings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #14470: [LLVM] Add missing `override` to GetFormat and GetPropertyMask

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #14470:
URL: https://github.com/apache/tvm/pull/14470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #14470: [LLVM] Add missing `override` to GetFormat and GetPropertyMask

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14470:
URL: https://github.com/apache/tvm/pull/14470#issuecomment-1495062724

   We can temp disable rust tests to unlock CI 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] kparzysz-quic commented on pull request #14470: [LLVM] Add missing `override` to GetFormat and GetPropertyMask

Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic commented on PR #14470:
URL: https://github.com/apache/tvm/pull/14470#issuecomment-1494970351

   The CPU build failure is due to
   ```
   failed to fetch `[https://github.com/rust-lang/crates.io-index`](https://github.com/rust-lang/crates.io-index%60)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14470: [LLVM] Add missing `override` to GetFormat and GetPropertyMask

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14470:
URL: https://github.com/apache/tvm/pull/14470#issuecomment-1494835966

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `llvm` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #14470: [LLVM] Add missing `override` to GetFormat and GetPropertyMask

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14470:
URL: https://github.com/apache/tvm/pull/14470#issuecomment-1496407621

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org