You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/08 18:35:31 UTC

[GitHub] [incubator-druid] pjain1 commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays

pjain1 commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays
URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344310873
 
 

 ##########
 File path: docs/operations/api-reference.md
 ##########
 @@ -752,7 +752,11 @@ Returns segment information lists including server locations for the given datas
 
 * `/druid/broker/v1/loadstatus`
 
-Returns a flag indicating if the Broker knows about all segments in Zookeeper. This can be used to know when a Broker process is ready to be queried after a restart.
+Returns a flag indicating if the Broker knows about all segments in the cluster. This can be used to know when a Broker process is ready to be queried after a restart.
+
+* `/druid/broker/v1/readiness`
 
 Review comment:
   `/readiness` already exists for historicals so I just extended it for brokers as well, the main reason for its existence is to know when the node is ready to serve queries as opposed to `/status` which just tells if process is up or not. Because of this reason I think we need two endpoints - one for checking when the process is ready to serve and another for checking if the process if up or not. Many monitoring systems rely on HTTP response codes to make decisions about service availability/readiness that's why I think `/readiness` was added even though `/loadstatus` already existed. BTW for health also we have two endpoints `/status` and `/status/health` introduced in https://github.com/apache/incubator-druid/pull/5087.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org