You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/09/02 05:12:08 UTC

[GitHub] trafficserver pull request #959: TS-4808: General diagnostics cleanup.

GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/959

    TS-4808: General diagnostics cleanup.

      - Clean up the Diags class to remove code duplication.
      - Switch all the diagnostic formatters over to using SourceLocation.
      - Remove useless mgmt_log functions which sometimes take stderr paramets.
      - Remove TSDiags() because it is awkward to pass a SourceLocation down.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/4808

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/959.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #959
    
----
commit 57e1374006c6b2bfe6aea0c9a8ca01f2af8875b1
Author: James Peach <jp...@apache.org>
Date:   2016-09-02T05:09:50Z

    TS-4808: General diagnostics cleanup.
    
      - Clean up the Diags class to remove code duplication.
      - Switch all the diagnostic formatters over to using SourceLocation.
      - Remove useless mgmt_log functions which sometimes take stderr paramets.
      - Remove TSDiags() because it is awkward to pass a SourceLocation down.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #959: TS-4808: General diagnostics cleanup.

Posted by zwoop <gi...@git.apache.org>.

Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/959
  
    ```C++
    ../../iocore/utils/diags.i: In function 'void reconfigure_diags()':
    ../../iocore/utils/diags.i:50:24: error: invalid conversion from 'int' to 'DiagsShowLocation' [-fpermissive]
       diags->show_location = 1;
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #959: TS-4808: General diagnostics cleanup.

Posted by zwoop <gi...@git.apache.org>.

Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/959
  
    I've tested this on OmniOS, and it compiled without problems. The changes seems reasonable to me, but they are also massive so real difficult to know if everything is correct :).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---