[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8263: bugfix:[Bug] [remote-rpc] the asynchronous call method cannot use oth…

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #8263:
URL: https://github.com/apache/dolphinscheduler/pull/8263#discussion_r795114697



##########
File path: dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/rpc/remote/NettyClient.java
##########
@@ -211,7 +211,8 @@ public RpcResponse sendMsg(Host host, RpcProtocol<RpcRequest> protocol, Boolean
         if (Boolean.TRUE.equals(async)) {
             result = new RpcResponse();
             result.setStatus((byte) 0);
-            result.setResult(true);
+            //firstly return a null value when meet the async call
+            result.setResult(null);

Review comment:
       It seems not the general processing if others need to judge `result==true`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org