[jira] [Commented] (IGNITE-6125) Improve robustness for JDBC driver metadata queries

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138659#comment-16138659 ] 

ASF GitHub Bot commented on IGNITE-6125:
----------------------------------------

GitHub user alamar opened a pull request:

    https://github.com/apache/ignite/pull/2506

    IGNITE-6125 Increase robustness of JDBC Metadata

    Avoid toUpperCase() where possible.
    Check that catalog matches to empty catalog.
    Ported several tests from Thin driver implementation.
    Fixed faulty toUpperCase() in Primary Keys metadata.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alamar/ignite ignite-6125

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2506
    
----
commit 0936d9e8ebbb4b4f4450a915791de728eaa6e845
Author: Ilya Kasnacheev <il...@gmail.com>
Date:   2017-08-18T11:40:42Z

    IGNITE-6125 Increase robustness of JDBC Metadata
    
    Avoid toUpperCase() where possible.
    Check that catalog matches to empty catalog.
    Ported several tests from Thin driver implementation.
    Fixed faulty toUpperCase() in Primary Keys metadata.

----


> Improve robustness for JDBC driver metadata queries
> ---------------------------------------------------
>
>                 Key: IGNITE-6125
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6125
>             Project: Ignite
>          Issue Type: Task
>          Components: clients, jdbc
>    Affects Versions: 2.1
>            Reporter: Ilya Kasnacheev
>            Assignee: Ilya Kasnacheev
>             Fix For: 2.2
>
>
> org.apache.ignite.internal.jdbc2.JdbcDatabaseMetadata is in worrysome state:
> - Makes frivolous use of toUpperCase() to address former.
> - getPrimaryKeys() never returns anything because of defective use of toUpperCase().
> - No tests on indexes, primary keys, schemas or parameters metadata retrieval.
> - Ignores "catalog" parameter instead of checking if it matches empty catalog.
> - See also IGNITE-6138, IGNITE-6139
> That should be fixes without compromising backwards compatibility too much. Tests may be borrowed from thin client implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)