You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by n-tran <gi...@git.apache.org> on 2015/11/11 00:52:47 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-953 Artifact equality...
GitHub user n-tran opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/142
TINKERPOP3-953 Artifact equality is not evaluating properly
https://issues.apache.org/jira/browse/TINKERPOP3-953
Corrected bug in artifact.equal where a local variable was overriding a member variable with the same name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP3-953
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 00583ecfd2eba9e8003d9b6dae47df0442000e47
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-11-10T01:01:29Z
Added unit test to Artifact
Corrected bug in artifact.equal where a local variable was overriding a member variable with the same name.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-953 Artifact equality...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-953 Artifact equality...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/142#issuecomment-155758973
This fixed a minor bug and added some good test coverage. Fairly trivial code wise. Merged via CTR. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---