[GitHub] [incubator-kvrocks] xiaobiaozhao opened a new issue, #1157: Fit redis driver

[GitBox <gi...@apache.org>]

xiaobiaozhao opened a new issue, #1157:
URL: https://github.com/apache/incubator-kvrocks/issues/1157

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   Hello! we are trying to use the Redis spark connector and found this possible issue:
   Here, the Redis version is reported as version:
   [incubator-kvrocks/src/server.cc](https://github.com/apache/incubator-kvrocks/blob/81d37927dfb2798138c8569af7c6a44dd376c3f4/src/server.cc#L783)
   
   Line 783 in [81d3792](https://github.com/apache/incubator-kvrocks/commit/81d37927dfb2798138c8569af7c6a44dd376c3f4)
   
    string_stream << "version:" << VERSION << "\r\n"; 
   
   But the Redis client expects a redis_version instead
   https://github.com/RedisLabs/spark-redis/blob/master/src/main/scala/com/redislabs/provider/redis/RedisConfig.scala#L229
   Apparently, for that reason, it is not able to connect.
   
   ### Solution
   
   ```c++
   string_stream << "version:" << VERSION << "\r\n"; 
   string_stream << "redis_version:" << REDIS_VERSION << "\r\n";  // 4.0
   string_stream << "kvrocks_version:" << VERSION << "\r\n"; 
   ```
   
   Keep the original `version` for compatible with the old kvrocks versions
   New `redis_version` for other drivers to recognize redis version
   New `kvrocks_version` for new directives of kvrocks that redis does not have
   
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk closed issue #1157: Add the compatible Redis version to the info command

[GitBox <gi...@apache.org>]

git-hulk closed issue #1157: Add the compatible Redis version to the info command
URL: https://github.com/apache/incubator-kvrocks/issues/1157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org