You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2021/02/19 16:16:34 UTC

[lucenenet] 01/02: Reviewd All codecs. No real issues found. Added comments and removed unneeded commented out using statements.

This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit b7367eb51912eeb9659b3678c7658dbf86041a9f
Author: Ron Clabo <ro...@GiftOasis.com>
AuthorDate: Thu Feb 18 17:03:27 2021 -0500

    Reviewd All codecs.  No real issues found. Added comments and removed unneeded commented out using statements.
---
 .../IntBlock/TestVariableIntBlockPostingsFormat.cs                    | 4 ----
 src/Lucene.Net.Tests.Codecs/Pulsing/Test10KPulsings.cs                | 2 +-
 .../SimpleText/TestSimpleTextPostingsFormat.cs                        | 2 +-
 .../SimpleText/TestSimpleTextStoredFieldsFormat.cs                    | 4 ++++
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/Lucene.Net.Tests.Codecs/IntBlock/TestVariableIntBlockPostingsFormat.cs b/src/Lucene.Net.Tests.Codecs/IntBlock/TestVariableIntBlockPostingsFormat.cs
index e9fd23a..6079e8a 100644
--- a/src/Lucene.Net.Tests.Codecs/IntBlock/TestVariableIntBlockPostingsFormat.cs
+++ b/src/Lucene.Net.Tests.Codecs/IntBlock/TestVariableIntBlockPostingsFormat.cs
@@ -21,10 +21,6 @@ namespace Lucene.Net.Codecs.IntBlock
      * limitations under the License.
      */
 
-    //using MockVariableIntBlockPostingsFormat = org.apache.lucene.codecs.mockintblock.MockVariableIntBlockPostingsFormat;
-    //using BasePostingsFormatTestCase = org.apache.lucene.index.BasePostingsFormatTestCase;
-    //using TestUtil = org.apache.lucene.util.TestUtil;
-    //using TestUtil = org.apache.lucene.util.TestUtil;
 
     /// <summary>
     /// Basic tests for VariableIntBlock
diff --git a/src/Lucene.Net.Tests.Codecs/Pulsing/Test10KPulsings.cs b/src/Lucene.Net.Tests.Codecs/Pulsing/Test10KPulsings.cs
index 19fd045..50aad55 100644
--- a/src/Lucene.Net.Tests.Codecs/Pulsing/Test10KPulsings.cs
+++ b/src/Lucene.Net.Tests.Codecs/Pulsing/Test10KPulsings.cs
@@ -68,7 +68,7 @@ namespace Lucene.Net.Codecs.Pulsing
             Field field = NewField("field", "", ft);
             document.Add(field);
 
-            //NumberFormat df = new DecimalFormat("00000", new DecimalFormatSymbols(Locale.ROOT));
+            //NumberFormat df = new DecimalFormat("00000", new DecimalFormatSymbols(Locale.ROOT));  // LUCENENET specific:  Use .ToString formating instead
 
             for (int i = 0; i < 10050; i++)
             {
diff --git a/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextPostingsFormat.cs b/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextPostingsFormat.cs
index f6c20dd..7038854 100644
--- a/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextPostingsFormat.cs
+++ b/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextPostingsFormat.cs
@@ -23,7 +23,7 @@ namespace Lucene.Net.Codecs.SimpleText
     /// Tests SimpleText's postings
     /// </summary>
     [Nightly] // please figure out why I am so horrendously slow!
-    public class TestSimpleTextPostingsFormat : BasePostingsFormatTestCase // please figure out why I am so horrendously slow!
+    public class TestSimpleTextPostingsFormat : BasePostingsFormatTestCase
     {
         private readonly Codec codec = new SimpleTextCodec();
 
diff --git a/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextStoredFieldsFormat.cs b/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextStoredFieldsFormat.cs
index be751b3..0c1f50c 100644
--- a/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextStoredFieldsFormat.cs
+++ b/src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextStoredFieldsFormat.cs
@@ -29,6 +29,10 @@ namespace Lucene.Net.Codecs.SimpleText
             return new SimpleTextCodec();
         }
 
+
+        // LUCENENET NOTE: Tests in an abstract base class are not pulled into the correct
+        // context in Visual Studio. This fixes that with the minimum amount of code necessary
+        // to run them in the correct context without duplicating all of the tests.
         [Deadlock][Timeout(600000)]
         public override void TestConcurrentReads()
         {