You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/03/14 02:48:56 UTC

[GitHub] [incubator-kvrocks] git-hulk opened a new pull request, #1320: Check if the checkpoint seq is in the WAL boundary before using

git-hulk opened a new pull request, #1320:
URL: https://github.com/apache/incubator-kvrocks/pull/1320

   This closes #1319 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1320: Check if the checkpoint seq is in the WAL boundary before using

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.

git-hulk commented on PR #1320:
URL: https://github.com/apache/incubator-kvrocks/pull/1320#issuecomment-1473960905

   Thanks all, merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1320: Check if the checkpoint seq is in the WAL boundary before using

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.

git-hulk commented on PR #1320:
URL: https://github.com/apache/incubator-kvrocks/pull/1320#issuecomment-1473071821

   This boundary check looks necessary but I can't reproduce this issue on my side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk merged pull request #1320: Check if the checkpoint seq is in the WAL boundary before using

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.

git-hulk merged PR #1320:
URL: https://github.com/apache/incubator-kvrocks/pull/1320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1320: Check if the checkpoint seq is in the WAL boundary before using

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.

git-hulk commented on PR #1320:
URL: https://github.com/apache/incubator-kvrocks/pull/1320#issuecomment-1473743785

   @torwig @caipengbo I extended the sequence limitation to require the checkpoint sequence must be greater or equal to the WAL sequence instead of strictly matching.
   
   ```
     if (seq < wal_seq) {
       return {Status::NotOK, fmt::format("checkpoint seq: {} is smaller than the WAL seq: {}", seq, wal_seq)};
     }
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org