You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/03/06 16:14:29 UTC
svn commit: r1887269 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
Author: tilman
Date: Sat Mar 6 16:14:29 2021
New Revision: 1887269
URL: http://svn.apache.org/viewvc?rev=1887269&view=rev
Log:
PDFBOX-4892: improve performance, as suggested by valerybokov; remove useless shift
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java?rev=1887269&r1=1887268&r2=1887269&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java Sat Mar 6 16:14:29 2021
@@ -58,7 +58,7 @@ public abstract class FDFAnnotation impl
/**
* An annotation flag.
*/
- private static final int FLAG_INVISIBLE = 1 << 0;
+ private static final int FLAG_INVISIBLE = 1;
/**
* An annotation flag.
*/
@@ -324,79 +324,78 @@ public abstract class FDFAnnotation impl
FDFAnnotation retval = null;
if (fdfDic != null)
{
- if (FDFAnnotationText.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ String fdfDicName = fdfDic.getNameAsString(COSName.SUBTYPE);
+ if (FDFAnnotationText.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationText(fdfDic);
}
- else if (FDFAnnotationCaret.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationCaret.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationCaret(fdfDic);
}
- else if (FDFAnnotationFreeText.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationFreeText.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationFreeText(fdfDic);
}
- else if (FDFAnnotationFileAttachment.SUBTYPE.equals(fdfDic
- .getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationFileAttachment.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationFileAttachment(fdfDic);
}
- else if (FDFAnnotationHighlight.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationHighlight.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationHighlight(fdfDic);
}
- else if (FDFAnnotationInk.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationInk.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationInk(fdfDic);
}
- else if (FDFAnnotationLine.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationLine.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationLine(fdfDic);
}
- else if (FDFAnnotationLink.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationLink.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationLink(fdfDic);
}
- else if (FDFAnnotationCircle.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationCircle.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationCircle(fdfDic);
}
- else if (FDFAnnotationSquare.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationSquare.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationSquare(fdfDic);
}
- else if (FDFAnnotationPolygon.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationPolygon.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationPolygon(fdfDic);
}
- else if (FDFAnnotationPolyline.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationPolyline.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationPolyline(fdfDic);
}
- else if (FDFAnnotationSound.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationSound.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationSound(fdfDic);
}
- else if (FDFAnnotationSquiggly.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationSquiggly.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationSquiggly(fdfDic);
}
- else if (FDFAnnotationStamp.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationStamp.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationStamp(fdfDic);
}
- else if (FDFAnnotationStrikeOut.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationStrikeOut.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationStrikeOut(fdfDic);
}
- else if (FDFAnnotationUnderline.SUBTYPE.equals(fdfDic.getNameAsString(COSName.SUBTYPE)))
+ else if (FDFAnnotationUnderline.SUBTYPE.equals(fdfDicName))
{
retval = new FDFAnnotationUnderline(fdfDic);
}
else
{
- LOG.warn("Unknown or unsupported annotation type '"
- + fdfDic.getNameAsString(COSName.SUBTYPE) + "'");
+ LOG.warn("Unknown or unsupported annotation type '" + fdfDicName + "'");
}
}
return retval;