You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/10 20:52:27 UTC
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #27953: Add timezone to dags in main screen
pierrejeambrun commented on code in PR #27953:
URL: https://github.com/apache/airflow/pull/27953#discussion_r1045134838
##########
airflow/models/dag.py:
##########
@@ -3204,6 +3204,13 @@ def __init__(self, concurrency=None, **kwargs):
def __repr__(self):
return f"<DAG: {self.dag_id}>"
+ @property
+ def schedule_description(self) -> str | None:
Review Comment:
Type is wrong here I believe:
```suggestion
def schedule_description(self) -> str:
```
##########
airflow/models/dag.py:
##########
@@ -3204,6 +3204,13 @@ def __init__(self, concurrency=None, **kwargs):
def __repr__(self):
return f"<DAG: {self.dag_id}>"
+ @property
+ def schedule_description(self) -> str | None:
Review Comment:
This is not enough, dataset triggered dag also have a schedule_interval as a string, I think we need to check the self.timetable attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org