You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/07/21 12:55:49 UTC
[jira] Created: (LANG-636) text.ExtendedMessageFormat doesn't
override java.text.MessageFormat.equals(Object)
text.ExtendedMessageFormat doesn't override java.text.MessageFormat.equals(Object)
----------------------------------------------------------------------------------
Key: LANG-636
URL: https://issues.apache.org/jira/browse/LANG-636
Project: Commons Lang
Issue Type: Bug
Components: lang.text.*
Reporter: Sebb
Fix For: 3.0
Findbugs:
Bug: org.apache.commons.lang3.text.ExtendedMessageFormat doesn't override java.text.MessageFormat.equals(Object)
Pattern id: EQ_DOESNT_OVERRIDE_EQUALS, type: Eq, category: STYLE
This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-636) text.ExtendedMessageFormat doesn't
override java.text.MessageFormat.equals(Object)
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910450#action_12910450 ]
Henri Yandell commented on LANG-636:
------------------------------------
Do you have a specific solution in mind?
> text.ExtendedMessageFormat doesn't override java.text.MessageFormat.equals(Object)
> ----------------------------------------------------------------------------------
>
> Key: LANG-636
> URL: https://issues.apache.org/jira/browse/LANG-636
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.text.*
> Reporter: Sebb
> Fix For: 3.0
>
>
> Findbugs:
> Bug: org.apache.commons.lang3.text.ExtendedMessageFormat doesn't override java.text.MessageFormat.equals(Object)
> Pattern id: EQ_DOESNT_OVERRIDE_EQUALS, type: Eq, category: STYLE
> This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.