[GitHub] [spark] cloud-fan commented on a change in pull request #30998: [SPARK-33933][SQL] Materialize BroadcastQueryState first to avoid broadcast timeout in AQE

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30998:
URL: https://github.com/apache/spark/pull/30998#discussion_r551123915



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -189,8 +189,17 @@ case class AdaptiveSparkPlanExec(
           stagesToReplace = result.newStages ++ stagesToReplace
           executionId.foreach(onUpdatePlan(_, result.newStages.map(_.plan)))
 
+          // SPARK-33933: We should materialize BroadcastQueryState first to avoid broadcast timeout
+          // Sort the new stages by class type to make sure BroadcastQueryState precede others

Review comment:
       nit:
   ```
   // SPARK-33933: we should submit tasks of broadcast stages first, to avoid broadcast timeout.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org