You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mohamed Nufail (JIRA)" <ji...@apache.org> on 2012/06/22 08:06:43 UTC
[jira] [Created] (DERBY-5827) Remove unused methods in
NetStatementReply class
Mohamed Nufail created DERBY-5827:
-------------------------------------
Summary: Remove unused methods in NetStatementReply class
Key: DERBY-5827
URL: https://issues.apache.org/jira/browse/DERBY-5827
Project: Derby
Issue Type: Task
Components: Network Client
Reporter: Mohamed Nufail
Priority: Minor
Code inspection of the NetStatementReply class shows that the following methods are not used at all.
parseQRYPRCTYP()
parseSQLCSRHLD()
parseQRYATTSCR()
parseQRYATTSET()
parseQRYATTSNS()
parseQRYATTUPD()
So it might be possible to remove these methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5827) Remove unused methods in
NetStatementReply class
Posted by "Mohamed Nufail (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mohamed Nufail updated DERBY-5827:
----------------------------------
Attachment: DERBY-5827.patch
Attached the patch DERBY-5827.patch which removes the above mentioned 6 methods
> Remove unused methods in NetStatementReply class
> ------------------------------------------------
>
> Key: DERBY-5827
> URL: https://issues.apache.org/jira/browse/DERBY-5827
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Priority: Minor
> Attachments: DERBY-5827.patch
>
>
> Code inspection of the NetStatementReply class shows that the following methods are not used at all.
> parseQRYPRCTYP()
> parseSQLCSRHLD()
> parseQRYATTSCR()
> parseQRYATTSET()
> parseQRYATTSNS()
> parseQRYATTUPD()
> So it might be possible to remove these methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5827) Remove unused methods in
NetStatementReply class
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404849#comment-13404849 ]
Bryan Pendleton commented on DERBY-5827:
----------------------------------------
I am reviewing this patch.
I looked at the svn history of NetStatementReply.java
http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java?view=annotate
and all of these methods seem to have been present since
the original contribution of this class to Derby, and have not been
modified since.
I also independently searched the code, and I agree that these
methods are entirely unused.
I'm intending to commit this patch. Deleting this unused code seems
fine, since the original implementation is still preserved in svn in case
we want to revive any of these methods in the future.
> Remove unused methods in NetStatementReply class
> ------------------------------------------------
>
> Key: DERBY-5827
> URL: https://issues.apache.org/jira/browse/DERBY-5827
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Priority: Minor
> Attachments: DERBY-5827.patch
>
>
> Code inspection of the NetStatementReply class shows that the following methods are not used at all.
> parseQRYPRCTYP()
> parseSQLCSRHLD()
> parseQRYATTSCR()
> parseQRYATTSET()
> parseQRYATTSNS()
> parseQRYATTUPD()
> So it might be possible to remove these methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5827) Remove unused methods in
NetStatementReply class
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-5827.
----------------------------------
> Remove unused methods in NetStatementReply class
> ------------------------------------------------
>
> Key: DERBY-5827
> URL: https://issues.apache.org/jira/browse/DERBY-5827
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Assignee: Mohamed Nufail
> Priority: Minor
> Fix For: 10.10.0.0
>
> Attachments: DERBY-5827.patch
>
>
> Code inspection of the NetStatementReply class shows that the following methods are not used at all.
> parseQRYPRCTYP()
> parseSQLCSRHLD()
> parseQRYATTSCR()
> parseQRYATTSET()
> parseQRYATTSNS()
> parseQRYATTUPD()
> So it might be possible to remove these methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5827) Remove unused methods in
NetStatementReply class
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton resolved DERBY-5827.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.10.0.0
My builds and tests were successful, and I've committed
this change to the trunk as revision 1356065.
> Remove unused methods in NetStatementReply class
> ------------------------------------------------
>
> Key: DERBY-5827
> URL: https://issues.apache.org/jira/browse/DERBY-5827
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Priority: Minor
> Fix For: 10.10.0.0
>
> Attachments: DERBY-5827.patch
>
>
> Code inspection of the NetStatementReply class shows that the following methods are not used at all.
> parseQRYPRCTYP()
> parseSQLCSRHLD()
> parseQRYATTSCR()
> parseQRYATTSET()
> parseQRYATTSNS()
> parseQRYATTUPD()
> So it might be possible to remove these methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DERBY-5827) Remove unused methods in
NetStatementReply class
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton reassigned DERBY-5827:
--------------------------------------
Assignee: Mohamed Nufail
Thanks Nufail!
> Remove unused methods in NetStatementReply class
> ------------------------------------------------
>
> Key: DERBY-5827
> URL: https://issues.apache.org/jira/browse/DERBY-5827
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Assignee: Mohamed Nufail
> Priority: Minor
> Fix For: 10.10.0.0
>
> Attachments: DERBY-5827.patch
>
>
> Code inspection of the NetStatementReply class shows that the following methods are not used at all.
> parseQRYPRCTYP()
> parseSQLCSRHLD()
> parseQRYATTSCR()
> parseQRYATTSET()
> parseQRYATTSNS()
> parseQRYATTUPD()
> So it might be possible to remove these methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira