You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/06/25 09:58:11 UTC
[GitHub] [cassandra] blerer opened a new pull request #1084: CASSANDRA-16737(4.0): Read only the required SSTables for single partition queries
blerer opened a new pull request #1084:
URL: https://github.com/apache/cassandra/pull/1084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #1084: CASSANDRA-16737(4.0): Read only the required SSTables for single partition queries
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #1084:
URL: https://github.com/apache/cassandra/pull/1084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #1084: CASSANDRA-16737(4.0): Read only the required SSTables for single partition queries
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #1084:
URL: https://github.com/apache/cassandra/pull/1084#discussion_r660836308
##########
File path: test/unit/org/apache/cassandra/cql3/validation/miscellaneous/SSTablesIteratedTest.java
##########
@@ -1333,7 +1358,9 @@ public void testNonCompactTableWithMultipleRegularColumnsAndColumnDeletion() thr
executeAndCheck("SELECT * FROM %s WHERE pk = 1", 3, row(1, null, 1));
executeAndCheck("SELECT v1, v2 FROM %s WHERE pk = 1", 3, row((Integer) null, 1));
- executeAndCheck("SELECT v1 FROM %s WHERE pk = 1", 3, row((Integer) null));
+ // As the primary key liveness is found on the second SSTable, we can stop there as it it enough to ensure
Review comment:
super nit, typo: it is enough that the row exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org