You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ssisk <gi...@git.apache.org> on 2017/06/28 22:44:34 UTC

[GitHub] beam pull request #3465: [BEAM-2537] GCP IO ITs now all use --project option

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/3465

    [BEAM-2537] GCP IO ITs now all use --project option

    Up until now, some IO ITs used --projectId and others used --project
    
    This mixing meant that running all the tests in one test run was
    impossible.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`.
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Today, the GPC IO ITs use a mix of --project and --projectId pipeline options. This change fixes it so all the GCP IO ITs use --project
    
    cc @mairbek 
    R: @jasonkuster @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam io_project_option

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3465
    
----
commit 6fe0e4fda2f688b118bf2a8c7d5e41720c9d0214
Author: Stephen Sisk <si...@google.com>
Date:   2017-06-28T22:34:45Z

    GCP IO ITs now all use --project option
    
    Up until now, some IO ITs used --projectId and others used --project
    
    This mixing meant that running all the tests in one test run was
    impossible.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3465: [BEAM-2537] GCP IO ITs now all use --project option

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3465


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---