You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/06 09:36:05 UTC
[GitHub] [dubbo-go] Patrick0308 opened a new pull request #587: Improve code coverage of nacos config center and configuration parser
Patrick0308 opened a new pull request #587:
URL: https://github.com/apache/dubbo-go/pull/587
Improve code coverage of nacos config center and configuration parser
relates #518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #587: Improve code coverage of nacos config center and configuration parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #587:
URL: https://github.com/apache/dubbo-go/pull/587#issuecomment-640022747
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/587?src=pr&el=h1) Report
> Merging [#587](https://codecov.io/gh/apache/dubbo-go/pull/587?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #587 +/- ##
===========================================
+ Coverage 66.80% 67.18% +0.37%
===========================================
Files 185 188 +3
Lines 9749 9849 +100
===========================================
+ Hits 6513 6617 +104
+ Misses 2600 2581 -19
- Partials 636 651 +15
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `56.45% <0.00%> (-6.46%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `75.00% <0.00%> (-6.37%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0.00%> (-4.85%)` | :arrow_down: |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `62.50% <0.00%> (ø)` | |
| [config\_center/mock\_dynamic\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9tb2NrX2R5bmFtaWNfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | |
| [config\_center/configuration\_listener.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0aW9uX2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <0.00%> (+9.61%)` | :arrow_up: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `75.21% <0.00%> (+19.65%)` | :arrow_up: |
| [config\_center/nacos/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWN0b3J5Lmdv) | `62.50% <0.00%> (+50.00%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/587?src=pr&el=footer). Last update [106040d...baf103d](https://codecov.io/gh/apache/dubbo-go/pull/587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] flycash merged pull request #587: Improve code coverage of nacos config center and configuration parser
Posted by GitBox <gi...@apache.org>.
flycash merged pull request #587:
URL: https://github.com/apache/dubbo-go/pull/587
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org