You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/27 18:55:24 UTC
[jira] [Commented] (FLINK-5681) Make ReaperThread for
SafetyNetCloseableRegistry a singleton
[ https://issues.apache.org/jira/browse/FLINK-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843321#comment-15843321 ]
ASF GitHub Bot commented on FLINK-5681:
---------------------------------------
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/3230
[FLINK-5681] Make ReaperThread for SafetyNetCloseableRegistry a singleton
Currently, each `SafetyNetCloseableRegistry` spawns an own ReaperThread. However, this duty could also be fulfilled by a single ReaperThread that is shared by all registries to save unnecessary threads.
This PR makes the reaper thread a singleton, because we could potentially create more registries now and it is not required to have one reaper thread per registry.
PR sits on top or #3229 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink safetyNetSingletonReaperThread
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3230
----
commit 31ae956fdd83a2f65bf22c3ad601d4d65ad61439
Author: Stefan Richter <s....@data-artisans.com>
Date: 2017-01-27T18:47:12Z
[FLINK-5663] Prevent leaking SafetyNetCloseableRegistry through InheritableThreadLocal
commit ec968c2e380ceb8403176b7744ed3b88ace3f340
Author: Stefan Richter <s....@data-artisans.com>
Date: 2017-01-27T18:51:21Z
[FLINK-5681] Make ReaperThread for SafetyNetCloseableRegistry a singleton
----
> Make ReaperThread for SafetyNetCloseableRegistry a singleton
> ------------------------------------------------------------
>
> Key: FLINK-5681
> URL: https://issues.apache.org/jira/browse/FLINK-5681
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> Currently, each {{SafetyNetCloseableRegistry}} spawns an own ReaperThread. However, this duty could also be fulfilled by a single ReaperThread that is shared by all registries to save unnecessary threads.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)