You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/27 05:10:57 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41340: [WIP] Remove some dependency in pom
panbingkun opened a new pull request, #41340:
URL: https://github.com/apache/spark/pull/41340
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41340: [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41340:
URL: https://github.com/apache/spark/pull/41340#issuecomment-1623108678
1.(Jersey depend on it) The first PR to introduce the dependency of `javax.ws.rs.javax.ws.rs-api`
PR: [SPARK-12154] Upgrade to Jersey 2
CommitID: b7fdc23ccc5967de5799d8cf6f14289e71f29a1e
https://github.com/apache/spark/commit/b7fdc23ccc5967de5799d8cf6f14289e71f29a1e#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R624-R627
<img width="521" alt="image" src="https://github.com/apache/spark/assets/15246973/9fd333c4-56f9-4cc7-9639-0f1c1a806dab">
2.Because Jersey depends on it, however, with the upgrade of Jersey version, the `rs-api` package name it depends on has been moved from: `javax.ws.rs.javax.ws.rs-api` to: `jakarta.ws.rs.jakarta.ws.rs-api` in version 2.28, but there is no corresponding removal in Spark.
- Jersey 2.27: https://repo1.maven.org/maven2/org/glassfish/jersey/project/2.27/project-2.27.pom
<img width="403" alt="image" src="https://github.com/apache/spark/assets/15246973/2c7b7dba-c515-4f46-80b6-b8b229c14004">
- Jersey 2.28: https://repo1.maven.org/maven2/org/glassfish/jersey/project/2.28/project-2.28.pom
<img width="402" alt="image" src="https://github.com/apache/spark/assets/15246973/74380102-3884-4f9d-b626-c58ac17b08a6">
- The PR that was modified in Jersey is: https://github.com/eclipse-ee4j/jersey/pull/3994
https://github.com/eclipse-ee4j/jersey/pull/3994/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R1363-R1364
3.
<img width="851" alt="image" src="https://github.com/apache/spark/assets/15246973/099f63c5-f5d9-4ceb-94db-dbdb7db57e3e">
4.In fact, we can only depends on `[jakarta.ws.rs](https://mvnrepository.com/artifact/jakarta.ws.rs) ยป [jakarta.ws.rs-api](https://mvnrepository.com/artifact/jakarta.ws.rs/jakarta.ws.rs-api)` in Spark because its package name has changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41340:
URL: https://github.com/apache/spark/pull/41340#issuecomment-1763217558
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41340: [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41340:
URL: https://github.com/apache/spark/pull/41340#issuecomment-1623110737
cc @LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #41340: [WIP] Remove some dependency in pom
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41340:
URL: https://github.com/apache/spark/pull/41340#issuecomment-1565495929
@panbingkun Can you explain why these two dependencies are no longer useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41340: [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41340:
URL: https://github.com/apache/spark/pull/41340#issuecomment-1623136050
There is no change on dependency manifest file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41340: [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41340:
URL: https://github.com/apache/spark/pull/41340#issuecomment-1623138861
> There is no change on dependency manifest file?
Yes, that's right, it doesn't exist in `spark-deps-hadoop-3-hive-2.3`.
Only the changed package exists:
<img width="568" alt="image" src="https://github.com/apache/spark/assets/15246973/1ee3eb74-1940-413c-a1f5-78311486aed8">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #41340: [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api
URL: https://github.com/apache/spark/pull/41340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org