You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/02 12:49:19 UTC
[GitHub] [skywalking] codecov-io commented on issue #4162: Support
collecting http parameters
codecov-io commented on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198164
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=h1) Report
> Merging [#4162](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5fba91901fe90865e2ad751d36e90a9fa2c70b7c?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `6.89%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4162/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4162 +/- ##
==========================================
+ Coverage 26.81% 26.84% +0.02%
==========================================
Files 1160 1161 +1
Lines 25381 25405 +24
Branches 3682 3687 +5
==========================================
+ Hits 6806 6819 +13
- Misses 17970 17978 +8
- Partials 605 608 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `68% <0%> (-2.84%)` | :arrow_down: |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0% <0%> (ø)` | |
| [...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh) | `100% <100%> (ø)` | :arrow_up: |
| [.../apm/plugin/tomcat78x/TomcatInvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdG9tY2F0LTcueC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vdG9tY2F0Nzh4L1RvbWNhdEludm9rZUludGVyY2VwdG9yLmphdmE=) | `58.97% <7.14%> (-29.49%)` | :arrow_down: |
| [...ion/consul/ConsulConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWNvbnN1bC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vY29uc3VsL0NvbnN1bENvbmZpZ3VyYXRpb25XYXRjaGVyUmVnaXN0ZXIuamF2YQ==) | `54% <0%> (+2.07%)` | :arrow_up: |
| [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `100% <0%> (+7.14%)` | :arrow_up: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=footer). Last update [5fba919...bae29cd](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services