[GitHub] [rocketmq] dugenkui03 commented on a diff in pull request #4152: [#4151]Add option p to the updateGlobalWhiteAddr command.

[GitBox <gi...@apache.org>]

dugenkui03 commented on code in PR #4152:
URL: https://github.com/apache/rocketmq/pull/4152#discussion_r847512176


##########
acl/src/main/java/org/apache/rocketmq/acl/AccessValidator.java:
##########
@@ -71,7 +71,7 @@
      *
      * @return
      */
-    boolean updateGlobalWhiteAddrsConfig(List<String> globalWhiteAddrsList);
+    boolean updateGlobalWhiteAddrsConfig(List<String> globalWhiteAddrsList, String aclFileFullPath);
 

Review Comment:
   建议新增`default`接口以保持对旧代码的兼容性，避免该接口成为重大变更/breaking change。而且两个方法分别对默认路径和指定路径进行更新、语义更加明确。
   ```java
      default boolean updateGlobalWhiteAddrsConfig(List<String> globalWhiteAddrsList, String aclFileFullPath) {
           return updateGlobalWhiteAddrsConfig(globalWhiteAddrsList);
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org