You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/15 02:09:10 UTC

[GitHub] [skywalking] LIU-WEI-git opened a new issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

LIU-WEI-git opened a new issue #7713:
URL: https://github.com/apache/skywalking/issues/7713


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   OAP server (apache/skywalking)
   
   ### What happened
   
   Comparing [H2EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java#L73) with [ESEventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/ESEventQueryDAO.java#L135) and [EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/EventQueryDAO.java#L116), you will find the latter two sort data by Event.START_TIME, but the first one doesn't. This difference has existed since PR #6183. I think it is a bug probably.
   
   ### What you expected to happen
   
   Add `order by` clause to those query SQL of H2EventQueryDAO.
   
   ### How to reproduce
   
   Just compare every implementation of IEventQueryDAO.
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919848053


   Hi @LIU-WEI-git , thank you for reporting this, the `H2EventQueryDAO` should use the same logic with `EventQueryDAO` and `ESEventQueryDAO`. The first condition serves as a prototype of the query condition list so we should not use the sum of limit size of all conditions as the result limit, which would be unreasonably large and not expected use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919848053


   Hi @LIU-WEI-git , thank you for reporting this, the `H2EventQueryDAO` should use the same logic with `EventQueryDAO` and `ESEventQueryDAO`. The first condition serves as a prototype of the query condition list so we should not use the sum of limit size of all conditions as the result limit, which would be unreasonable large and not expected use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7713:
URL: https://github.com/apache/skywalking/issues/7713


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] LIU-WEI-git commented on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919850453


   Got it. I will submit a PR soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919848053


   Hi @LIU-WEI-git , thank you for reporting this, the `EventQueryDAO` and `ESEventQueryDAO` should use the same logic with `H2EventQueryDAO`. The first condition serves as a prototype of the query condition list so we should not use the sum of limit size of all conditions as the result limit, which would be unreasonable large and not expected use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] LIU-WEI-git commented on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919666431


   [EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/EventQueryDAO.java#L73) and [ESEventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/ESEventQueryDAO.java#L128) use the pagination ("limit" and "from") of the first condition. However, [H2EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java#L115) adopts the [sum of limit size of all condition](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c9
 1b0d0/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java#L100) with out offset. Should I modify H2EventQueryDAO according to the other two?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] LIU-WEI-git edited a comment on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
LIU-WEI-git edited a comment on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919666431


   [EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/EventQueryDAO.java#L73) and [ESEventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/ESEventQueryDAO.java#L128) use the pagination ("limit" and "from") of the first condition. However, [H2EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java#L115) adopts the [sum of limit size of all condition](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c9
 1b0d0/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java#L100) with out offset. Should I modify H2EventQueryDAO according to the other two? @wu-sheng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919668376


   I am not sure what does first condition mean. @kezhenxu94 should know more than me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org