You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/15 04:01:22 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1495: [CALCITE-3399] RelFieldTrimmer trim fields for UNION, INTERSECT, INTE…

jinxing64 commented on a change in pull request #1495: [CALCITE-3399] RelFieldTrimmer trim fields for UNION, INTERSECT, INTE…
URL: https://github.com/apache/calcite/pull/1495#discussion_r334743876
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java
 ##########
 @@ -697,14 +697,20 @@ public TrimResult trimFields(
 
   /**
    * Variant of {@link #trimFields(RelNode, ImmutableBitSet, Set)} for
-   * {@link org.apache.calcite.rel.core.SetOp} (including UNION and UNION ALL).
+   * {@link org.apache.calcite.rel.core.Union}.
 
 Review comment:
   @hsyuan 
   How about we keep the API interface as before and only do the trimming when type of `SetOp` is union ?
   How do you think ?
   But it seems weird since Calcite really means to only trim Union and it's incorrect by semantics on other operators.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services