You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2014/10/11 01:13:38 UTC

svn commit: r1631004 - in /jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans: example2/Example2BeanInfo.java example3/Example3BeanInfo.java

Author: sebb
Date: Fri Oct 10 23:13:37 2014
New Revision: 1631004

URL: http://svn.apache.org/r1631004
Log:
Ensure all properties are minimally configured

Modified:
    jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2BeanInfo.java
    jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example3/Example3BeanInfo.java

Modified: jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2BeanInfo.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2BeanInfo.java?rev=1631004&r1=1631003&r2=1631004&view=diff
==============================================================================
--- jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2BeanInfo.java (original)
+++ jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2BeanInfo.java Fri Oct 10 23:13:37 2014
@@ -23,6 +23,6 @@ import org.apache.jmeter.testbeans.BeanI
 public class Example2BeanInfo extends BeanInfoSupport {
     public Example2BeanInfo() {
         super(Example2.class);
-        // ...
+        property("myStringProperty").setValue(DEFAULT, "");
     }
 }

Modified: jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example3/Example3BeanInfo.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example3/Example3BeanInfo.java?rev=1631004&r1=1631003&r2=1631004&view=diff
==============================================================================
--- jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example3/Example3BeanInfo.java (original)
+++ jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example3/Example3BeanInfo.java Fri Oct 10 23:13:37 2014
@@ -26,7 +26,9 @@ import org.apache.jmeter.testbeans.gui.T
 public class Example3BeanInfo extends BeanInfoSupport {
 
     private PropertyDescriptor getprop(String name) {
-        return property(name);
+        final PropertyDescriptor property = property(name);
+        property.setValue(NOT_UNDEFINED, Boolean.FALSE); // Ensure it is not flagged as 'unconfigured'
+        return property;
     }
 
     private PropertyDescriptor getprop(String name, Object deflt) {
@@ -38,17 +40,18 @@ public class Example3BeanInfo extends Be
 
     public Example3BeanInfo() {
         super(Example3.class);
-        getprop("mybool");
+        getprop("mybool", Boolean.TRUE); // Must use defaults for primitive types
         getprop("myBoolean1");
-        getprop("myBoolean2", "True");
-        getprop("myInt", "77");
+        getprop("myBoolean2", Boolean.TRUE);
+        getprop("myInt", Integer.valueOf(77)); // Must use defaults for primitive types
         getprop("myInteger1");
         getprop("myInteger2", Integer.valueOf(123));
-        getprop("mylong", "99");
+        getprop("mylong", Long.valueOf(99)); // Must use defaults for primitive types
         getprop("myLong1");
         getprop("myLong2", Long.valueOf(456));
         getprop("myString1");
         getprop("myString2","abcd");
+        getprop("myFile1");
         property("myFile2", TypeEditor.FileEditor);
     }
 }