You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 11:41:47 UTC
[GitHub] [arrow-datafusion] Igosuki opened a new pull request #1795: Arrow2 02092022
Igosuki opened a new pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795
# Which issue does this PR close?
None
Closes #.
# Rationale for this change
Keep the arrow2 branch up to date
# What changes are included in this PR?
Uses the improved parquet io code, switched to blocking FileWriter for writing parquet as File isn't AsyncWrite.
# Are there any user-facing changes?
Nope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1795: Arrow2 02092022
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795#issuecomment-1061541786
@Igosuki that's great, I tried to manually unsquash the previous commit commits, but it turned out to be too much work and not worth it. I took a quick look at your arrow2 branch and it looks clean without those two squashed commits. I think we can just force push your arrow2 branch into the one in datafusion's repo, then use merge commits going forward for future catch ups. If you are ok with this approach, please feel free to send a PR, once reviewed by the community, I can help perform the force push to replace the current arrow2 branch.
https://git-scm.com/docs/gitfaq#long-running-squash-merge has guidance on how to best maintain long running branches, which should help explain why merge commits will help make future merges easier.
Once we have the arrow2 branch updated, I will get back to performance testing. I remember running into a performance regression around window queries, so that would be the next thing I will dig into.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp edited a comment on pull request #1795: Arrow2 02092022
Posted by GitBox <gi...@apache.org>.
houqp edited a comment on pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795#issuecomment-1060323355
@Igosuki @alamb mind if I force update the arrow2 branch with the latest commit from this PR (79107650f5d04165aef6009a46d0289e615b34aa)? I am thinking it will be easier to manage long running branches using merge commits instead of squash commits so we can keep the full history from master in the arrow2 branch. Right now all commits from master branch got squashed into a single commit into the arrow2 branch every time we merge a PR.
Or do you all prefer to use squash commits instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1795: Arrow2 02092022
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795#issuecomment-1060323355
@Igosuki @alamb mind if I force update the arrow2 branch with the latest commit from this PR (79107650f5d04165aef6009a46d0289e615b34aa)? I am thinking it will be easier to manage long running branches using merge commits instead of squash commits so we can keep the full history from master in the arrow2 branch. Right now all commits from master branch got squashed into a single commit into the arrow2 branch every time we merge a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Igosuki commented on pull request #1795: Arrow2 02092022
Posted by GitBox <gi...@apache.org>.
Igosuki commented on pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795#issuecomment-1060421622
Yep I actually did a merge with latest here
https://github.com/Igosuki/Arrow-Datafusion/tree/arrow2 should I make a new
PR ?
I now understand why it was so hard to merge all the time 😅
Le lun. 7 mars 2022 à 09:29, QP Hou ***@***.***> a écrit :
> @Igosuki <https://github.com/Igosuki> @alamb <https://github.com/alamb>
> mind if I force update the arrow2 branch with the latest commit from this
> PR (7910765
> <https://github.com/apache/arrow-datafusion/commit/79107650f5d04165aef6009a46d0289e615b34aa>)?
> I am thinking it will be easier to manage long running branches using merge
> commits instead of squash commits so we can keep the full history from
> master in the arrow2 branch. Right now all commits from master branch got
> squashed into a single commit into the arrow2 branch every time we merge a
> PR.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow-datafusion/pull/1795#issuecomment-1060323355>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADDFBSJ3427NEZICSHBPN3U6W443ANCNFSM5N5HXOPQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Igosuki commented on pull request #1795: Arrow2 02092022
Posted by GitBox <gi...@apache.org>.
Igosuki commented on pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795#issuecomment-1037064579
Added a fix for avro projections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1795: Arrow2 02092022
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1795: Arrow2 02092022
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1795:
URL: https://github.com/apache/arrow-datafusion/pull/1795#issuecomment-1060620309
> mind if I force update the arrow2 branch with the latest commit from this PR
I do not mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org