You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/20 19:48:10 UTC
[GitHub] [incubator-iceberg] rdblue opened a new pull request #940: Fix thread safety in listeners and simplify implementation
rdblue opened a new pull request #940:
URL: https://github.com/apache/incubator-iceberg/pull/940
The thread safety in `Listeners` was incorrect. It was locking on a concurrent map, then updating the resulting value list outside the lock unsafely.
This updates to delegate lookup and initialization to the concurrent map using `computeIfAbsent`, and changes the map values to concurrent queues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #940: Fix thread safety in listeners and simplify implementation
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #940:
URL: https://github.com/apache/incubator-iceberg/pull/940#issuecomment-617275992
Thanks for reviewing, @rdsr!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org