You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2016/03/16 05:45:00 UTC
spark git commit: [MINOR][TEST][SQL] Remove wrong "expected"
parameter in checkNaNWithoutCodegen
Repository: spark
Updated Branches:
refs/heads/master bbd887f53 -> 52b6a899b
[MINOR][TEST][SQL] Remove wrong "expected" parameter in checkNaNWithoutCodegen
## What changes were proposed in this pull request?
Remove the wrong "expected" parameter in MathFunctionsSuite.scala's checkNaNWithoutCodegen.
This function is to check NaN value, so the "expected" parameter is useless. The Callers do not pass "expected" value and the similar function like checkNaNWithGeneratedProjection and checkNaNWithOptimization do not use it also.
Author: Yucai Yu <yu...@intel.com>
Closes #11718 from yucai/unused_expected.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/52b6a899
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/52b6a899
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/52b6a899
Branch: refs/heads/master
Commit: 52b6a899be2711568d86ab99d1a2b4d1f9fef286
Parents: bbd887f
Author: Yucai Yu <yu...@intel.com>
Authored: Tue Mar 15 21:44:58 2016 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Tue Mar 15 21:44:58 2016 -0700
----------------------------------------------------------------------
.../apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/52b6a899/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
index fba5f53..d6ac404 100644
--- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
+++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
@@ -122,7 +122,6 @@ class MathFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper {
private def checkNaNWithoutCodegen(
expression: Expression,
- expected: Any,
inputRow: InternalRow = EmptyRow): Unit = {
val actual = try evaluate(expression, inputRow) catch {
case e: Exception => fail(s"Exception evaluating $expression", e)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org