[GitHub] [ozone] kuenishi commented on a change in pull request #2763: HDDS-5893. Potential data loss on multipart upload commit

[GitBox <gi...@apache.org>]

kuenishi commented on a change in pull request #2763:
URL: https://github.com/apache/ozone/pull/2763#discussion_r735323777



##########
File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/s3/multipart/TestS3MultipartUploadCompleteResponseWithFSO.java
##########
@@ -186,17 +235,14 @@ public void testAddDBToBatchWithParts() throws Exception {
     Assert.assertNull(omMetadataManager.getOpenKeyTable(getBucketLayout())
         .get(dbMultipartOpenKey));
 
-    // As 1 unused parts exists, so 1 unused entry should be there in delete
-    // table.
-    deleteEntryCount++;
-    Assert.assertEquals(deleteEntryCount, omMetadataManager.countRowsInTable(
-            omMetadataManager.getDeletedTable()));

Review comment:
       Weird thing here is even before this patch, this assertion contradicts with the above comment, which states `deleteEntryCount` is 2 here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org