You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/08/05 16:00:29 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #540: Migrate the classic remoting to Netty 4.
He-Pin opened a new pull request, #540:
URL: https://github.com/apache/incubator-pekko/pull/540
Based on https://github.com/apache/incubator-pekko/pull/539
For a preview, may not be landing in 1.1.0 if community dediced to remove the classic remoting in 1.1.0.
Personally, I vote we remove the classic remoting in 1.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #540: Migrate the classic remoting to Netty 4.
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #540:
URL: https://github.com/apache/incubator-pekko/pull/540#issuecomment-1666572198
The Pekko community conversation is at https://lists.apache.org/thread/grzp3jw398rtpc6oqfybzxnry2mtyh64
I would just prefer to see consensus there before we consider merging a PR. There's no harm in testing this solution but I'd prefer if it wasn't merged until the community decides on what we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin closed pull request #540: WIP: Migrate the classic remoting to Netty 4.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #540: WIP: Migrate the classic remoting to Netty 4.
URL: https://github.com/apache/incubator-pekko/pull/540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #540: WIP: Migrate the classic remoting to Netty 4.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #540:
URL: https://github.com/apache/incubator-pekko/pull/540#issuecomment-1695730294
I see the value of keep it and upgrade to Netty 4, but it will need more time to polish too, if it's pr is doomed and will not get merged, then maybe better not put more time on it.
Maybe @pjfanning could share some views too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #540: Migrate the classic remoting to Netty 4.
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #540:
URL: https://github.com/apache/incubator-pekko/pull/540#issuecomment-1666544469
The discussion on pekko mailing list has not reached a conclusion. I agree with @jrudolph that we are better off removing classic remoting. His point is that it is very hard to test remoting and there is no need to have 2 styles.
So -1 from me on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #540: WIP: Migrate the classic remoting to Netty 4.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #540:
URL: https://github.com/apache/incubator-pekko/pull/540#issuecomment-1695674721
Your free to close the PR if you want but as was pointed out in https://www.reddit.com/r/scala/comments/160pvne/comment/jxnuvbf/?utm_source=reddit&utm_medium=web2x&context=3 if we decide to strictly follow semver we may not have a choice here unless we want to ship code with CVE's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #540: WIP: Migrate the classic remoting to Netty 4.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #540:
URL: https://github.com/apache/incubator-pekko/pull/540#issuecomment-1695622728
@pjfanning and @mdedetrich as The poll result, I think I will close this PR.
https://www.reddit.com/r/scala/comments/160pvne/upgrade_pekkos_classical_transport_to_netty_4_or/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #540: Migrate the classic remoting to Netty 4.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #540:
URL: https://github.com/apache/incubator-pekko/pull/540#issuecomment-1666572933
> The Pekko community conversation is at https://lists.apache.org/thread/grzp3jw398rtpc6oqfybzxnry2mtyh64
>
> I would just prefer to see consensus there before we consider merging a PR. There's no harm in testing this solution but I'd prefer if it wasn't merged until the community decides on what we want.
That's true, I was testing the idea in this draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org