You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/09/12 02:03:32 UTC
Review Request 68696: Eliminating an unnecessary copy when devolving a
scheduler call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68696/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Repository: mesos
Description
-------
Eliminating an unnecessary copy when devolving a scheduler call.
Diffs
-----
src/internal/devolve.cpp a5d9ab92a4b808f1030c38b9ae48ee4b1386a306
Diff: https://reviews.apache.org/r/68696/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 68696: Eliminating an unnecessary copy when
devolving a scheduler call.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68696/#review208645
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Sept. 11, 2018, 7:03 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68696/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2018, 7:03 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Eliminating an unnecessary copy when devolving a scheduler call.
>
>
> Diffs
> -----
>
> src/internal/devolve.cpp a5d9ab92a4b808f1030c38b9ae48ee4b1386a306
>
>
> Diff: https://reviews.apache.org/r/68696/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68696: Eliminating an unnecessary copy when
devolving a scheduler call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68696/#review208540
-----------------------------------------------------------
PASS: Mesos patch 68696 was successfully built and tested.
Reviews applied: `['68695', '68696']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2323/mesos-review-68696
- Mesos Reviewbot Windows
On Sept. 12, 2018, 2:03 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68696/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2018, 2:03 a.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Eliminating an unnecessary copy when devolving a scheduler call.
>
>
> Diffs
> -----
>
> src/internal/devolve.cpp a5d9ab92a4b808f1030c38b9ae48ee4b1386a306
>
>
> Diff: https://reviews.apache.org/r/68696/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>