You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/19 09:08:47 UTC

[GitHub] [dolphinscheduler] SnowMoon-Dev opened a new pull request, #10130: [doc]update editorial workflow content and images

SnowMoon-Dev opened a new pull request, #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Brief change log
   
   1. update editorial workflow content and images
   2. update project overview picture
   
   ## Verify this pull request
   
   Manually verified the change by testing locally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#issuecomment-1132643241

   > @zhongjiajie Do you have any other better suggestions?
   
   no, well done @SnowMoon-Dev  and thanks for you contribution, merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#discussion_r876858263


##########
docs/docs/zh/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **编辑：** 只能编辑已终止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，在弹框中勾选"是否更新到工作流定义"，保存后则更新工作流定义；若不勾选，则不更新工作流定义。
+- **编辑：** 只能编辑已停止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，修改流程定义信息，在弹框中勾选"是否上传流程定义"，保存后则将实例修改的信息更新到工作流定义；若不勾选，则不更新工作流定义。

Review Comment:
   只有工作流实例状态在```成功/失败/停止```中的时候可以被编辑。



##########
docs/docs/en/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@ Click Project Management -> Workflow -> Workflow Instance, enter the workflow in
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **Edit：** only can edit terminated processes. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to update to workflow definition" to update the workflow definition; if not checked, no effect on the workflow definition
+- **Edit：** only can edit terminated processes. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to upload to workflow definition" to update instance modified information to workflow definition; if not checked, no effect on the workflow definition

Review Comment:
   Only workflow instance state in ```successed/failed/killed``` can be edited.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#discussion_r876864112


##########
docs/docs/zh/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **编辑：** 只能编辑已终止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，在弹框中勾选"是否更新到工作流定义"，保存后则更新工作流定义；若不勾选，则不更新工作流定义。
+- **编辑：** 只能编辑已停止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，修改流程定义信息，在弹框中勾选"是否上传流程定义"，保存后则将实例修改的信息更新到工作流定义；若不勾选，则不更新工作流定义。

Review Comment:
   成功和失败都是重跑，没有编辑选项的



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#discussion_r876892710


##########
docs/docs/en/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@ Click Project Management -> Workflow -> Workflow Instance, enter the workflow in
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **Edit：** only can edit terminated processes. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to update to workflow definition" to update the workflow definition; if not checked, no effect on the workflow definition
+- **Edit：** only can edit terminated processes. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to upload to workflow definition" to update instance modified information to workflow definition; if not checked, no effect on the workflow definition

Review Comment:
   ok, I modified the corresponding content



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#issuecomment-1131945660

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10130)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10130&resolved=false&types=CODE_SMELL)
   
   [![50.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50-16px.png '50.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10130&metric=new_coverage&view=list) [50.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10130&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10130&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10130&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#discussion_r876864112


##########
docs/docs/zh/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **编辑：** 只能编辑已终止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，在弹框中勾选"是否更新到工作流定义"，保存后则更新工作流定义；若不勾选，则不更新工作流定义。
+- **编辑：** 只能编辑已停止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，修改流程定义信息，在弹框中勾选"是否上传流程定义"，保存后则将实例修改的信息更新到工作流定义；若不勾选，则不更新工作流定义。

Review Comment:
   成功和失败都是重跑，没有编辑选项的



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#discussion_r876911106


##########
docs/docs/zh/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **编辑：** 只能编辑已终止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，在弹框中勾选"是否更新到工作流定义"，保存后则更新工作流定义；若不勾选，则不更新工作流定义。
+- **编辑：** 只能编辑 成功/失败/停止 状态的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，修改流程定义信息，在弹框中勾选"是否上传流程定义"，保存后则将实例修改的信息更新到工作流定义；若不勾选，则不更新工作流定义。

Review Comment:
   是否上传流程定义 修改为 是否更新工作流定义



##########
docs/docs/en/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@ Click Project Management -> Workflow -> Workflow Instance, enter the workflow in
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **Edit：** only can edit terminated processes. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to update to workflow definition" to update the workflow definition; if not checked, no effect on the workflow definition
+- **Edit：** only processes with success/failed/stop status can be edited. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to upload to workflow definition" to update instance modified information to workflow definition; if not checked, no effect on the workflow definition

Review Comment:
   ```Whether to upload to workflow definition``` change to ```Whether to update to workflow definition```
   
   ```no effect on the workflow definition``` change to ```the workflow definition would not be updated```.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#discussion_r877270544


##########
docs/docs/en/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@ Click Project Management -> Workflow -> Workflow Instance, enter the workflow in
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **Edit：** only can edit terminated processes. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to update to workflow definition" to update the workflow definition; if not checked, no effect on the workflow definition
+- **Edit：** only processes with success/failed/stop status can be edited. Click the "Edit" button or the workflow instance name to enter the DAG edit page. After the edit, click the "Save" button to confirm, as shown in the figure below. In the pop-up box, check "Whether to upload to workflow definition" to update instance modified information to workflow definition; if not checked, no effect on the workflow definition

Review Comment:
   @SbloodyS Thanks, I have modified the relevant content.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#issuecomment-1132597122

   @zhongjiajie Do you have any other suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10130: [doc]update editorial workflow content and images

Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10130:
URL: https://github.com/apache/dolphinscheduler/pull/10130#discussion_r876892230


##########
docs/docs/zh/guide/project/workflow-instance.md:
##########
@@ -40,7 +40,7 @@
 
 ![workflow-instance](/img/new_ui/dev/project/workflow-instance.png)
 
-- **编辑：** 只能编辑已终止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，在弹框中勾选"是否更新到工作流定义"，保存后则更新工作流定义；若不勾选，则不更新工作流定义。
+- **编辑：** 只能编辑已停止的流程。点击"编辑"按钮或工作流实例名称进入 DAG 编辑页面，编辑后点击"保存"按钮，弹出保存 DAG 弹框，如下图所示，修改流程定义信息，在弹框中勾选"是否上传流程定义"，保存后则将实例修改的信息更新到工作流定义；若不勾选，则不更新工作流定义。

Review Comment:
   好的，我更改了相应的内容



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org